Refactor ChangeVarNodesExtended() using the custom callback
authorAlexander Korotkov <akorotkov@postgresql.org>
Sat, 3 May 2025 19:30:52 +0000 (22:30 +0300)
committerAlexander Korotkov <akorotkov@postgresql.org>
Sat, 3 May 2025 19:30:52 +0000 (22:30 +0300)
commit250a718aadad68793e82103282247556a46a3cfc
tree61287bfc020c2fc899c4e4a2fbefd622b5424c5a
parentfb21ed6c38da719149443e78048790c0347e2c9b
Refactor ChangeVarNodesExtended() using the custom callback

fc069a3a6319 implemented Self-Join Elimination (SJE) and put related logic
to ChangeVarNodes_walker().  This commit provides refactoring to remove the
SJE-related logic from ChangeVarNodes_walker() but adds a custom callback to
ChangeVarNodesExtended(), which has a chance to process a node before
ChangeVarNodes_walker().  Passing this callback to ChangeVarNodesExtended()
allows SJE-related node handling to be kept within the analyzejoins.c.

Reported-by: Richard Guo <guofenglinux@gmail.com>
Discussion: https://postgr.es/m/CAMbWs49PE3CvnV8vrQ0Dr%3DHqgZZmX0tdNbzVNJxqc8yg-8kDQQ%40mail.gmail.com
Author: Andrei Lepikhov <lepihov@gmail.com>
Author: Alexander Korotkov <aekorotkov@gmail.com>
src/backend/optimizer/plan/analyzejoins.c
src/backend/rewrite/rewriteManip.c
src/include/rewrite/rewriteManip.h
src/tools/pgindent/typedefs.list