Heikki Linnakangas [Thu, 23 Apr 2009 10:20:27 +0000 (10:20 +0000)]
Mention that tables have a visibility map fork alongside the main fork
and FSM.
Heikki Linnakangas [Thu, 23 Apr 2009 10:09:11 +0000 (10:09 +0000)]
Improve the documentation on 8.4 visibility map related VACUUM changes.
Explain how vacuum_freeze_table_age should be tuned, and how it relates
to the other settings. Mention that vacuum_freeze_table_age also affects
when autovacuum scans the whole table.
Heikki Linnakangas [Thu, 23 Apr 2009 07:19:09 +0000 (07:19 +0000)]
varstr_cmp and any comparison function that piggybacks on it can return
any negative or positive number, not just -1 or 1. Fix comment on
varstr_cmp and citext test case accordingly.
As pointed out by Zdenek Kotala, and buildfarm member gothic moth.
Tom Lane [Thu, 23 Apr 2009 00:23:46 +0000 (00:23 +0000)]
Change the default value of max_prepared_transactions to zero, and add
documentation warnings against setting it nonzero unless active use of
prepared transactions is intended and a suitable transaction manager has been
installed. This should help to prevent the type of scenario we've seen
several times now where a prepared transaction is forgotten and eventually
causes severe maintenance problems (or even anti-wraparound shutdown).
The only real reason we had the default be nonzero in the first place was to
support regression testing of the feature. To still be able to do that,
tweak pg_regress to force a nonzero value during "make check". Since we
cannot force a nonzero value in "make installcheck", add a variant regression
test "expected" file that shows the results that will be obtained when
max_prepared_transactions is zero.
Also, extend the HINT messages for transaction wraparound warnings to mention
the possibility that old prepared transactions are causing the problem.
All per today's discussion.
Heikki Linnakangas [Wed, 22 Apr 2009 19:51:12 +0000 (19:51 +0000)]
After archive recovery, mark the last WAL segment from the parent timeline
ready for archival. It was marked at the next checkpoint anyway, but
waiting for the next checkpoint is an unnecessary delay.
Fujii Masao
Bruce Momjian [Wed, 22 Apr 2009 14:58:48 +0000 (14:58 +0000)]
Use brackets in psql \df \? help.
Tom Lane [Tue, 21 Apr 2009 21:15:50 +0000 (21:15 +0000)]
Remove the long-obsolete homebrew dl*() functions for AIX, in favor of just
using the system functions all the time. (These files are now just copies
of the osf.* files.) The homebrew functions were not getting used anyway
on AIX versions that have dlopen(), that is 4.3 and up, so they are not
needed on any AIX that is even remotely supported by the vendor anymore.
We'd have probably left them here anyway, except some questions were
raised about the copyright.
Tom Lane [Tue, 21 Apr 2009 21:05:25 +0000 (21:05 +0000)]
Fix obsolete cross-reference (this file isn't called alpha.c anymore)
Bruce Momjian [Tue, 21 Apr 2009 17:28:01 +0000 (17:28 +0000)]
Improve psql \df error handling.
David Fetter
Bruce Momjian [Tue, 21 Apr 2009 17:23:05 +0000 (17:23 +0000)]
Merge psql \df options into a single \? line, and update docs.
Bruce Momjian [Tue, 21 Apr 2009 15:49:06 +0000 (15:49 +0000)]
Add agg/normal/trigger/window flags for psql \df and in \df output.
David Fetter
Magnus Hagander [Mon, 20 Apr 2009 08:38:00 +0000 (08:38 +0000)]
Read nls.nk files to determine the proper name of NLS catalogs to install.
Hiroshi Inoue, with minor modifications by me
Tom Lane [Sun, 19 Apr 2009 22:37:13 +0000 (22:37 +0000)]
Assorted portability fixes for Borland C, from Pavel Golub.
Tom Lane [Sun, 19 Apr 2009 21:50:09 +0000 (21:50 +0000)]
Rethink the idea of having plpgsql depend on parser/gram.h. Aside from the
fact that this is breaking the MSVC build, it's probably not really a good
idea to expand the dependencies of gram.h any further than the core parser;
for instance the value of SCONST might depend on which bison version you'd
built with. Better to expose an additional call point in parser.c, so
move what I had put into pl_funcs.c into parser.c. Also PGDLLIMPORT'ify
the reference to standard_conforming_strings, per buildfarm results.
Tom Lane [Sun, 19 Apr 2009 21:08:54 +0000 (21:08 +0000)]
Fix de-escaping checks so that we will reject \000 as well as other invalidly
encoded sequences. Per discussion of a couple of days ago.
Tom Lane [Sun, 19 Apr 2009 20:36:06 +0000 (20:36 +0000)]
Fix textsearch documentation examples to not recommend concatenating separate
fields without putting a space between. Per gripe from Rick Schumeyer.
Tom Lane [Sun, 19 Apr 2009 19:46:33 +0000 (19:46 +0000)]
Fix estimate_num_groups() to not fail on PlaceHolderVars, per report from
Stefan Kaltenbrunner. The most reasonable behavior (at least for the near
term) seems to be to ignore the PlaceHolderVar and examine its argument
instead. In support of this, change the API of pull_var_clause() to allow
callers to request recursion into PlaceHolderVars. Currently
estimate_num_groups() is the only customer for that behavior, but where
there's one there may be others.
Tom Lane [Sun, 19 Apr 2009 18:52:58 +0000 (18:52 +0000)]
Revise plpgsql's scanner to process comments and string literals in a way
more nearly matching the core SQL scanner. The user-visible effects are:
* Block comments (slash-star comments) now nest, as per SQL spec.
* In standard_conforming_strings mode, backslash as the last character of a
non-E string literal is now correctly taken as an ordinary character;
formerly it was misinterpreted as escaping the ending quote. (Since the
string also had to pass through the core scanner, this invariably led
to syntax errors.)
* Formerly, backslashes in the format string of RAISE were always treated as
quoting the next character, regardless of mode. Now, they are ordinary
characters with standard_conforming_strings on, while with it off, they
introduce the same set of escapes as in the core SQL scanner. Also,
escape_string_warning is now effective for RAISE format strings. These
changes make RAISE format strings work just like any other string literal.
This is implemented by copying and pasting a lot of logic from the core
scanner. It would be a good idea to look into getting rid of plpgsql's
scanner entirely in favor of using the core scanner. However, that involves
more change than I can justify making during beta --- in particular, the core
scanner would have to become re-entrant.
In passing, remove the kluge that made the plpgsql scanner emit T_FUNCTION or
T_TRIGGER as a made-up first token. That presumably had some value once upon
a time, but now it's just useless complication for both the scanner and the
grammar.
Tom Lane [Sun, 19 Apr 2009 15:49:34 +0000 (15:49 +0000)]
Mention as a potential incompatibility the fact that SELECT DISTINCT, UNION,
etc are no longer guaranteed to produce sorted output; per gripe from Ian
Barwick. Also improve the release note entries about to_timestamp(), per
Brendan Jurd.
Bruce Momjian [Sat, 18 Apr 2009 00:01:01 +0000 (00:01 +0000)]
Add Ron Mayer as primary contributor for:
Support the <acronym>IS0 8601</> <type>interval</> syntax
based on private email from Ron.
Tom Lane [Fri, 17 Apr 2009 15:33:33 +0000 (15:33 +0000)]
Bump disable_cost up from 1e8 to 1e10, per gripe from Kris Jurka.
Tom Lane [Thu, 16 Apr 2009 20:42:16 +0000 (20:42 +0000)]
Fix planner to restore its previous level of intelligence about pushing
constants through full joins, as in
select * from tenk1 a full join tenk1 b using (unique1)
where unique1 = 42;
which should generate a fairly cheap plan where we apply the constraint
unique1 = 42 in each relation scan. This had been broken by my patch of
2008-06-27, which is now reverted in favor of a more invasive but hopefully
less incorrect approach. That patch was meant to prevent incorrect extraction
of OR'd indexclauses from OR conditions above an outer join. To do that
correctly we need more information than the outerjoin_delay flag can provide,
so add a nullable_relids field to RestrictInfo that records exactly which
relations are nulled by outer joins that are underneath a particular qual
clause. A side benefit is that we can make the test in create_or_index_quals
more specific: it is now smart enough to extract an OR'd indexclause into the
outer side of an outer join, even though it must not do so in the inner side.
The old coding couldn't distinguish these cases so it could not do either.
Alvaro Herrera [Thu, 16 Apr 2009 14:43:39 +0000 (14:43 +0000)]
Fix the regression test error message for array_fill, too.
Per note from Andrew Dunstan.
Alvaro Herrera [Wed, 15 Apr 2009 23:30:33 +0000 (23:30 +0000)]
Substitute extraneous underscores with spaces.
Bruce Momjian [Wed, 15 Apr 2009 22:42:50 +0000 (22:42 +0000)]
Remove mention of pre-7.1 inheritance behavior from /ref pages; keep
mentions in main documentation.
Alvaro Herrera [Wed, 15 Apr 2009 21:42:50 +0000 (21:42 +0000)]
Add missing gettext calls around some strings. Also remove quotes around the
%s that they expand to, per comment from Tom.
Alvaro Herrera [Wed, 15 Apr 2009 21:36:12 +0000 (21:36 +0000)]
Add missing periods.
Magnus Hagander [Wed, 15 Apr 2009 18:58:24 +0000 (18:58 +0000)]
Remove beer-ware license from crypt-md5.c, per
approval from Poul-Henning Kamp.
This makes the file the same standard 2-clause BSD as the
rest of PostgreSQL.
Bruce Momjian [Wed, 15 Apr 2009 13:03:11 +0000 (13:03 +0000)]
Fix SGML markup I broke yesterday.
Tom Lane [Tue, 14 Apr 2009 22:18:47 +0000 (22:18 +0000)]
Fix broken {xufailed} production that made HEAD fail on
select u&42 from table-with-a-u-column;
Also fix missing SET_YYLLOC() in the {dolqfailed} production that I suppose
this was based on. The latter is a pre-existing bug, but the only effect
is to misplace the error cursor by one token, so probably not worth
backpatching.
Bruce Momjian [Tue, 14 Apr 2009 20:42:48 +0000 (20:42 +0000)]
Reformat 'sslmode' options into an SGML table; improve wording.
Bruce Momjian [Tue, 14 Apr 2009 17:30:16 +0000 (17:30 +0000)]
Add libpq error message text on how to handle missing root.crt file.
Tom Lane [Tue, 14 Apr 2009 00:49:56 +0000 (00:49 +0000)]
Do some copy-editing on description of ts_headline().
Alvaro Herrera [Tue, 14 Apr 2009 00:06:35 +0000 (00:06 +0000)]
pg_restore -jN does not equate "multiple jobs", so partly revert the
previous patch.
Per note from Tom.
Alvaro Herrera [Mon, 13 Apr 2009 21:03:36 +0000 (21:03 +0000)]
Make new strings more alike previously existing messages.
Tom Lane [Mon, 13 Apr 2009 06:05:12 +0000 (06:05 +0000)]
Make a copy-editing pass over the 8.4 release notes.
Andrew Dunstan [Sun, 12 Apr 2009 21:02:44 +0000 (21:02 +0000)]
Fix logic to detect conflicts or blocks involving exclusive locks in parallel restore items.
If a currently running item needs an exclusive lock on any item that the candidate items needs
any sort of lock on, or vice versa, then the candidate item is not allowed to run now, and
must wait till later.
Tom Lane [Sat, 11 Apr 2009 20:23:05 +0000 (20:23 +0000)]
Fix pg_dumpall so that when --clean is specified, it drops roles and
tablespaces in an order that has some chance of working.
Per a complaint from Kevin Bailey.
This is a pre-existing bug, but given the lack of prior complaints I'm
not sure it's worth back-patching. In most cases failure of the DROP
commands wouldn't be that important anyway.
In passing, fix syntax errors in dumpCreateDB()'s queries for old servers;
these were apparently introduced in recent binary_upgrade patch.
Alvaro Herrera [Sat, 11 Apr 2009 18:38:54 +0000 (18:38 +0000)]
Make string more alike other similar messages.
Bruce Momjian [Sat, 11 Apr 2009 16:46:54 +0000 (16:46 +0000)]
More wording clarification of sslverify setting.
Peter Eisentraut [Sat, 11 Apr 2009 14:11:45 +0000 (14:11 +0000)]
Message fix
(I guess this was a cruise replace mistake.)
Peter Eisentraut [Sat, 11 Apr 2009 14:11:21 +0000 (14:11 +0000)]
Message improvement
Bruce Momjian [Sat, 11 Apr 2009 12:27:53 +0000 (12:27 +0000)]
Better document libpq sslverify behavior as requiring root.crt.
Bruce Momjian [Sat, 11 Apr 2009 02:08:34 +0000 (02:08 +0000)]
Wording improvement.
Bruce Momjian [Sat, 11 Apr 2009 02:07:25 +0000 (02:07 +0000)]
Wording improvement for SSL user certificate authentication.
Bruce Momjian [Sat, 11 Apr 2009 02:06:16 +0000 (02:06 +0000)]
Clarify SSL _user_ authentication in release notes.
Tom Lane [Fri, 10 Apr 2009 17:56:21 +0000 (17:56 +0000)]
Add cross-references from the DECLARE and FETCH reference pages to
the plpgsql documentation about cursors. Per a suggestion from
Matthew Wakeling.
Bruce Momjian [Fri, 10 Apr 2009 03:13:36 +0000 (03:13 +0000)]
Document how *_blks_read statistics columns are computed.
Marc G. Fournier [Fri, 10 Apr 2009 00:20:10 +0000 (00:20 +0000)]
commit and tag beta1
Tom Lane [Thu, 9 Apr 2009 23:22:49 +0000 (23:22 +0000)]
Update release notes through yesterday; some minor wordsmithing.
Bruce Momjian [Thu, 9 Apr 2009 22:32:02 +0000 (22:32 +0000)]
Clarify documentation references to pg_stat_get_blocks_fetched and
pg_stat_get_blocks_hit, per suggestion from Robert Haas.
Bruce Momjian [Thu, 9 Apr 2009 21:50:31 +0000 (21:50 +0000)]
No more need to update FAQs.
Peter Eisentraut [Thu, 9 Apr 2009 21:35:33 +0000 (21:35 +0000)]
Add URL for config.guess/sub updates
Peter Eisentraut [Thu, 9 Apr 2009 21:33:02 +0000 (21:33 +0000)]
Update config.guess and config.sub
Tom Lane [Thu, 9 Apr 2009 20:50:42 +0000 (20:50 +0000)]
Update time zone data files to tzdata release 2009e: DST law changes in
Argentina/San_Luis, Cuba, Jordan (historical correction only), Morocco,
Palestine, Syria, Tunisia.
Peter Eisentraut [Thu, 9 Apr 2009 19:38:53 +0000 (19:38 +0000)]
Translation updates for 8.4 beta
Tom Lane [Thu, 9 Apr 2009 19:07:44 +0000 (19:07 +0000)]
Update GIN limitations documentation to match current reality.
Tom Lane [Thu, 9 Apr 2009 17:39:50 +0000 (17:39 +0000)]
Remove SQL-compatibility function cardinality(). It is not exactly clear
how this ought to behave for multi-dimensional arrays. Per discussion,
not having it at all seems better than having it with what might prove
to be the wrong behavior. We can always add it later when we have consensus
on the correct behavior.
Bruce Momjian [Thu, 9 Apr 2009 16:20:50 +0000 (16:20 +0000)]
Improve documentation about how checkpoint spreads I/O activity.
Tom Lane [Thu, 9 Apr 2009 14:21:02 +0000 (14:21 +0000)]
Treat EOF like \n for line-counting purposes in ParseConfigFile,
per bug #4752. Fujii Masao
Tom Lane [Thu, 9 Apr 2009 02:57:53 +0000 (02:57 +0000)]
Fix the plpgsql memory leak exhibited in bug #4677. That leak was introduced
by my patch of 2007-01-28 to use per-subtransaction ExprContexts/EStates:
since we re-prepared any expression tree when the current subtransaction ID
changed, we'd accumulate more and more leaked expression state trees in the
outermost subtransaction if the same function was executed at multiple levels
of subtransaction nesting. To fix, go back to the previous scheme where
there was only one EState per transaction for simple plpgsql expressions.
We really only need an ExprContext per subtransaction, not a whole EState,
so it's possible to keep prepared expression state trees in the one EState
throughout the transaction. This should be more efficient as well as not
leaking memory for cases involving lots of subtransactions.
The added regression test is the case that inspired the 2007-01-28 patch in
the first place, just to make sure we didn't go backwards. The current
memory leak complaint is unfortunately hard to test for in the regression
test framework, though manual testing shows it's fixed.
Although this is a pre-existing bug, I'm not back-patching because I'd like to
see this method get some field testing first. Consider back-patching if it
gets through 8.4beta unscathed.
Tom Lane [Wed, 8 Apr 2009 22:29:30 +0000 (22:29 +0000)]
Remove psql's ancient hack that suppressed functions taking or returning
cstring from the output of \df. Now that the default behavior is to
exclude all system functions, the de-cluttering rationale for this behavior
seems pretty weak; and it was always quite confusing/unhelpful if you were
actually looking for I/O functions. (Not to mention if you were looking
for encoding converters or other cases that might take or return cstring.)
Tom Lane [Wed, 8 Apr 2009 22:08:40 +0000 (22:08 +0000)]
Allow leading and trailing spaces around NaN in numeric_in.
Sam Mason, rewritten a bit by Tom.
Peter Eisentraut [Wed, 8 Apr 2009 21:51:38 +0000 (21:51 +0000)]
XMLATTRIBUTES() should send the attribute values through
map_sql_value_to_xml_value() instead of directly through the data type output
function. This is per SQL standard, and consistent with XMLELEMENT().
Heikki Linnakangas [Wed, 8 Apr 2009 19:02:37 +0000 (19:02 +0000)]
Quote string literals correctly in the new CREATE SERVER statements
and binary upgrade UPDATE statements.
Heikki Linnakangas [Wed, 8 Apr 2009 13:08:09 +0000 (13:08 +0000)]
Oops, mustn't call textdomain() when compiling without --enable-nls
Heikki Linnakangas [Wed, 8 Apr 2009 09:50:48 +0000 (09:50 +0000)]
Tell gettext which codeset to use by calling bind_textdomain_codeset(). We
already did that on Windows, but it's needed on other platforms too when
LC_CTYPE=C. With other locales, we enforce (or trust) that the codeset of
the locale matches the server encoding so we don't need to bind it
explicitly. It should do no harm in that case either, but I don't have
full faith in the PG encoding -> OS codeset mapping table yet. Per recent
discussion on pgsql-hackers.
Bruce Momjian [Wed, 8 Apr 2009 04:05:16 +0000 (04:05 +0000)]
Improve tab completion for \ef.
Andrew Gierth
Bruce Momjian [Tue, 7 Apr 2009 23:27:34 +0000 (23:27 +0000)]
Revert addition of units to GUC descriptions; doesn't affect
postgresql.conf.
Bruce Momjian [Tue, 7 Apr 2009 22:48:30 +0000 (22:48 +0000)]
Disable effective_io_concurrency on Solaris because posix_fadvise() is
no-op on that platform.
Bruce Momjian [Tue, 7 Apr 2009 22:22:19 +0000 (22:22 +0000)]
More GUC units doc updates.
Euler Taveira de Oliveira
Bruce Momjian [Tue, 7 Apr 2009 21:30:01 +0000 (21:30 +0000)]
Add attribution for:
Add Japanese message translations (Japan PostgreSQL Users Group)
Bruce Momjian [Tue, 7 Apr 2009 21:29:02 +0000 (21:29 +0000)]
Add release note item:
Add Japanese message translations
Bruce Momjian [Tue, 7 Apr 2009 21:20:49 +0000 (21:20 +0000)]
Remove FAQ and FAQ_DEV ASCII and HTML files from CVS; now on the wiki.
Per-language files kept for transator usage.
Magnus Hagander [Tue, 7 Apr 2009 19:35:57 +0000 (19:35 +0000)]
Support Perl 5.10 and TCL 8.5 in MSVC builds.
We should probably have a better way to do this (meaning
something not hardcoded) eventually, but this fixes the
problem for 8.4.
Dave Page
Tom Lane [Tue, 7 Apr 2009 17:57:50 +0000 (17:57 +0000)]
Remove useless (leftover?) extern declaration.
Tom Lane [Tue, 7 Apr 2009 15:53:54 +0000 (15:53 +0000)]
Defend against non-ASCII letters in fuzzystrmatch code. The functions
still don't behave very sanely for multibyte encodings, but at least
they won't be indexing off the ends of static arrays.
Bruce Momjian [Tue, 7 Apr 2009 04:02:41 +0000 (04:02 +0000)]
Add doc link to section about how to compile triggers.
Tom Lane [Tue, 7 Apr 2009 00:31:26 +0000 (00:31 +0000)]
Add an optional parameter to pg_start_backup() that specifies whether to do
the checkpoint in immediate or lazy mode. This is to address complaints
that pg_start_backup() takes a long time even when there's no need to minimize
its I/O consumption.
Bruce Momjian [Mon, 6 Apr 2009 21:00:52 +0000 (21:00 +0000)]
Add unit documentation for various postgresql.conf settings.
Peter Eisentraut [Mon, 6 Apr 2009 19:34:52 +0000 (19:34 +0000)]
Add entry in the encoding number to OS name table for KOI8-U.
Bruce Momjian [Mon, 6 Apr 2009 19:03:04 +0000 (19:03 +0000)]
Properly align equals signs in new postgresql.conf units comments.
Bruce Momjian [Mon, 6 Apr 2009 19:00:18 +0000 (19:00 +0000)]
Document in postgresql.conf that the default units for
log_min_duration_statement is milliseconds.
Bruce Momjian [Mon, 6 Apr 2009 18:40:47 +0000 (18:40 +0000)]
Display postgresql.conf unit options in an easier-to-understand,
2-column format.
Bruce Momjian [Mon, 6 Apr 2009 17:56:31 +0000 (17:56 +0000)]
Doc change in new patch, stand-alone -> standalone
Bruce Momjian [Mon, 6 Apr 2009 17:55:19 +0000 (17:55 +0000)]
Add documentation mention of 'check_postgres.pl' in Routine Database
Maintenance Tasks section.
Bruce Momjian [Mon, 6 Apr 2009 15:50:59 +0000 (15:50 +0000)]
Adjust psql tab completion for new \d 'S' flag behavior; adjust code to
be more flexible about additional modifiers for \d commands.
Tom Lane [Mon, 6 Apr 2009 15:43:00 +0000 (15:43 +0000)]
Document the fact that fuzzystrmatch doesn't work in multibyte encodings.
Tom Lane [Mon, 6 Apr 2009 15:01:36 +0000 (15:01 +0000)]
Correct keywords table for status of COLLATE vs
LC_COLLATE.
Teodor Sigaev [Mon, 6 Apr 2009 14:27:27 +0000 (14:27 +0000)]
Fix 'all at one page bug' in picksplit method of R-tree emulation. Add defense
from buggy user-defined picksplit to GiST.
Heikki Linnakangas [Mon, 6 Apr 2009 08:42:53 +0000 (08:42 +0000)]
Rename the new CREATE DATABASE options to set collation and ctype into
LC_COLLATE and LC_CTYPE, per discussion on pgsql-hackers.
Tom Lane [Sun, 5 Apr 2009 22:28:59 +0000 (22:28 +0000)]
Change cardinality() into a C-code function, instead of a SQL-language
alias for array_length(v,1). The efficiency gain here is doubtless
negligible --- what I'm interested in is making sure that if we have
second thoughts about the definition, we will not have to force a
post-beta initdb to change the implementation.
Tom Lane [Sun, 5 Apr 2009 20:32:06 +0000 (20:32 +0000)]
Make ExecInitExpr build the list of SubPlans found in a plan tree in order
of discovery, rather than reverse order. This doesn't matter functionally
(I suppose the previous coding dates from the time when lcons was markedly
cheaper than lappend). However now that EXPLAIN is labeling subplans with
IDs that are based on order of creation, this may help produce a slightly
less surprising printout.
Tom Lane [Sun, 5 Apr 2009 19:59:40 +0000 (19:59 +0000)]
Change EXPLAIN output so that subplans and initplans (particularly CTEs)
are individually labeled, rather than just grouped under an "InitPlan"
or "SubPlan" heading. This in turn makes it possible for decompilation of
a subplan reference to usefully identify which subplan it's referencing.
I also made InitPlans identify which parameter symbol(s) they compute,
so that references to those parameters elsewhere in the plan tree can
be connected to the initplan that will be executed. Per a gripe from
Robert Haas about EXPLAIN output of a WITH query being inadequate,
plus some longstanding pet peeves of my own.
Teodor Sigaev [Sun, 5 Apr 2009 11:32:01 +0000 (11:32 +0000)]
Fix infinite loop while checking of partial match in pending list.
Improve comments. Now GIN-indexable operators should be strict.
Per Tom's questions/suggestions.
Tom Lane [Sun, 5 Apr 2009 04:19:59 +0000 (04:19 +0000)]
Remove a boatload of useless definitions of 'int optreset'. If we
are using our own ports of getopt or getopt_long, those will define
the variable for themselves; and if not, we don't need these, because
we never touch the variable anyway.
Tom Lane [Sun, 5 Apr 2009 04:09:01 +0000 (04:09 +0000)]
I had always wondered why pg_config.h.win32 claimed that Windows
provides optreset. Current mastodon results prove that in fact it
does not; it was only because getopt.c defined the variable anyway
that things failed to fall over.
Tom Lane [Sun, 5 Apr 2009 00:40:35 +0000 (00:40 +0000)]
Remove contrib/intarray's definitions of the <@ and @> operators, so that they
don't cause confusion with the built-in anyarray versions of those operators.
Adjust the module's index opclasses to support the built-in operators in place
of the private ones.
The private implementations are still available under their historical
names @ and ~, so no functionality is lost. Some quick testing suggests
that they offer no real benefit over the core operators, however.
Per a complaint from Rusty Conover.
Tom Lane [Sat, 4 Apr 2009 22:36:11 +0000 (22:36 +0000)]
Hmm, baiji thinks we need explicit 'extern' here.
Tom Lane [Sat, 4 Apr 2009 21:55:50 +0000 (21:55 +0000)]
Make an attempt at fixing our current Solaris 11 breakage: add a configure
probe for opterr (exactly like the one for optreset) and have getopt.c
define the variables only if configure doesn't find them in libc.