Fix for SF BUG #470 Can't list/see/edit sequences owned by group

While I have implemented this fix against Postgres 12, as far as I can tell,
this bug existed since 7.x, so I'm adding it to all versions back to 7.4
(when we did the class re-org). This could probably use more testing on older
versions though.

Thanks to Carlos Martinez for the bug report and reproducible test case!

diff --git a/classes/database/Postgres.php b/classes/database/Postgres.php
index ca649ec71a080f346a6a78cb19d3d08703c33c92..12103b7785ef1b6fac84da9cb1a801e76c5f17b8 100644 (file)
--- a/classes/database/Postgres.php
+++ b/classes/database/Postgres.php
@@ -2664,20 +2664,40 @@ class Postgres extends ADODB_base {
        function getSequences($all = false) {
                if ($all) {
                        // Exclude pg_catalog and information_schema tables
-                       $sql = "SELECT n.nspname, c.relname AS seqname, u.usename AS seqowner
-                               FROM pg_catalog.pg_class c, pg_catalog.pg_user u, pg_catalog.pg_namespace n
-                               WHERE c.relowner=u.usesysid AND c.relnamespace=n.oid
-                               AND c.relkind = 'S'
-                               AND n.nspname NOT IN ('pg_catalog', 'information_schema', 'pg_toast')
-                               ORDER BY nspname, seqname";
+                       $sql = "
+                                       SELECT
+                                               n.nspname, 
+                                               c.relname AS seqname, 
+                                               pg_catalog.pg_get_userbyid(c.relowner) as seqowner
+                                       FROM
+                                               pg_catalog.pg_class c 
+                                               JOIN pg_catalog.pg_namespace n ON n.oid = c.relnamespace
+                                       WHERE 
+                                               c.relkind IN ('S')
+                                               AND n.nspname NOT IN ('pg_catalog','information_schema')
+                                               AND n.nspname !~ '^pg_toast'
+                                               AND pg_catalog.pg_table_is_visible(c.oid)
+                                       ORDER BY 
+                                               nspname, seqname;";
                } else {
                        $c_schema = $this->_schema;
                        $this->clean($c_schema);
-                       $sql = "SELECT c.relname AS seqname, u.usename AS seqowner, pg_catalog.obj_description(c.oid, 'pg_class') AS seqcomment,
-                               (SELECT spcname FROM pg_catalog.pg_tablespace pt WHERE pt.oid=c.reltablespace) AS tablespace
-                               FROM pg_catalog.pg_class c, pg_catalog.pg_user u, pg_catalog.pg_namespace n
-                               WHERE c.relowner=u.usesysid AND c.relnamespace=n.oid
-                               AND c.relkind = 'S' AND n.nspname='{$c_schema}' ORDER BY seqname";
+                       $sql = "
+                                       SELECT
+                                               n.nspname, 
+                                               c.relname AS seqname, 
+                                               pg_catalog.obj_description(c.oid, 'pg_class') AS seqcomment,
+                                               (SELECT spcname FROM pg_catalog.pg_tablespace pt WHERE pt.oid=c.reltablespace) AS tablespace, 
+                                               pg_catalog.pg_get_userbyid(c.relowner) as seqowner
+                                       FROM
+                                               pg_catalog.pg_class c 
+                                               JOIN pg_catalog.pg_namespace n ON n.oid = c.relnamespace
+                                       WHERE 
+                                               c.relkind IN ('S')
+                                               AND n.nspname = '{$c_schema}' 
+                                               AND pg_catalog.pg_table_is_visible(c.oid)
+                                       ORDER BY 
+                                               nspname, seqname;";
                }
 
                return $this->selectSet( $sql );