The code to unlink dropped relations in FinishPreparedTransaction() was

acting like runs inside WAL recovery, but it doesn't. I must've copy-pasted
this from a redo-function in the relation forks patch. Noticed by Tom Lane
while he was looking through callers of smgrdounlink().

diff --git a/src/backend/access/transam/twophase.c b/src/backend/access/transam/twophase.c
index c6aaecae0d6795c1d4de2cc4164a12a581b7b466..9434f8ff2ef9825243c42d034dd7eca7d8c2e831 100644 (file)
--- a/src/backend/access/transam/twophase.c
+++ b/src/backend/access/transam/twophase.c
@@ -1241,10 +1241,7 @@ FinishPreparedTransaction(const char *gid, bool isCommit)
                for (fork = 0; fork <= MAX_FORKNUM; fork++)
                {
                        if (smgrexists(srel, fork))
-                       {
-                               XLogDropRelation(delrels[i], fork);
-                               smgrdounlink(srel, fork, false, true);
-                       }
+                               smgrdounlink(srel, fork, false, false);
                }
                smgrclose(srel);
        }