Suppress compiler warning in non-cassert builds.
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 26 Aug 2020 21:08:11 +0000 (17:08 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 26 Aug 2020 21:08:11 +0000 (17:08 -0400)
Oversight in 808e13b28, reported by Bruce Momjian.

Discussion: https://postgr.es/m/20200826160251.GB21909@momjian.us

src/backend/storage/file/sharedfileset.c

index 65fd8ff5c0c3e22f07add592bbb7cee42f823726..8b96e81fffff9251408d0445e0f130e4d71a7098 100644 (file)
@@ -285,7 +285,6 @@ SharedFileSetDeleteOnProcExit(int status, Datum arg)
 void
 SharedFileSetUnregister(SharedFileSet *input_fileset)
 {
-   bool        found = false;
    ListCell   *l;
 
    /*
@@ -303,12 +302,12 @@ SharedFileSetUnregister(SharedFileSet *input_fileset)
        if (input_fileset == fileset)
        {
            filesetlist = list_delete_cell(filesetlist, l);
-           found = true;
-           break;
+           return;
        }
    }
 
-   Assert(found);
+   /* Should have found a match */
+   Assert(false);
 }
 
 /*