Drop const cast from dlsym() calls

This workaround might be obsolete.  We'll see if those "older
platforms" mentioned in the comment are still around.

Discussion: https://www.postgresql.org/message-id/08adbe4e-38f8-2c73-55f0-591392371687%402ndquadrant.com

diff --git a/src/backend/utils/fmgr/dfmgr.c b/src/backend/utils/fmgr/dfmgr.c
index 4a5cc7cfc7f53a77bddba96a8a5c04cfd08f71aa..04c8aa8eef0216c70f93c0297fcdf791bd680fa4 100644 (file)
--- a/src/backend/utils/fmgr/dfmgr.c
+++ b/src/backend/utils/fmgr/dfmgr.c
@@ -121,12 +121,8 @@ load_external_function(const char *filename, const char *funcname,
    if (filehandle)
        *filehandle = lib_handle;
 
-   /*
-    * Look up the function within the library.  According to POSIX dlsym()
-    * should declare its second argument as "const char *", but older
-    * platforms might not, so for the time being we just cast away const.
-    */
-   retval = (PGFunction) dlsym(lib_handle, (char *) funcname);
+   /* Look up the function within the library. */
+   retval = (PGFunction) dlsym(lib_handle, funcname);
 
    if (retval == NULL && signalNotFound)
        ereport(ERROR,
@@ -174,8 +170,7 @@ load_file(const char *filename, bool restricted)
 PGFunction
 lookup_external_function(void *filehandle, const char *funcname)
 {
-   /* as above, cast away const for the time being */
-   return (PGFunction) dlsym(filehandle, (char *) funcname);
+   return (PGFunction) dlsym(filehandle, funcname);
 }