Tighten some regexes with proper character escaping in pg_dump TAP tests

Some tests have been using regular expressions which have been lax in
escaping dots, which may cause tests to pass when they should not.  This
make the whole set of tests more robust where needed.

Author: David Rowley
Reviewed-by: Daniel Gustafsson, Michael Paquier
Discussion: https://postgr.es/m/CAKJS1f9jD8aVo1BTH+Vgwd=f-ynbuRVrS90XbWMT6UigaOQJTA@mail.gmail.com

diff --git a/src/bin/pg_dump/t/002_pg_dump.pl b/src/bin/pg_dump/t/002_pg_dump.pl
index 245fcbf5ce987319863c77d7b02480399dfbbf55..f70b88cab2f3a992b45e9731eed1144a704851ce 100644 (file)
--- a/src/bin/pg_dump/t/002_pg_dump.pl
+++ b/src/bin/pg_dump/t/002_pg_dump.pl
@@ -448,7 +448,7 @@ my %tests = (
        },
 
        'ALTER COLLATION test0 OWNER TO' => {
-               regexp    => qr/^ALTER COLLATION public.test0 OWNER TO .*;/m,
+               regexp    => qr/^\QALTER COLLATION public.test0 OWNER TO \E.*;/m,
                collation => 1,
                like      => { %full_runs, section_pre_data => 1, },
                unlike    => { %dump_test_schema_runs, no_owner => 1, },
@@ -757,7 +757,7 @@ my %tests = (
        },
 
        'ALTER TABLE test_table OWNER TO' => {
-               regexp => qr/^ALTER TABLE dump_test.test_table OWNER TO .*;/m,
+               regexp => qr/^\QALTER TABLE dump_test.test_table OWNER TO \E.*;/m,
                like   => {
                        %full_runs,
                        %dump_test_schema_runs,
@@ -776,7 +776,7 @@ my %tests = (
                create_sql   => 'ALTER TABLE dump_test.test_table
                                           ENABLE ROW LEVEL SECURITY;',
                regexp =>
-                 qr/^ALTER TABLE dump_test.test_table ENABLE ROW LEVEL SECURITY;/m,
+                 qr/^\QALTER TABLE dump_test.test_table ENABLE ROW LEVEL SECURITY;\E/m,
                like => {
                        %full_runs,
                        %dump_test_schema_runs,
@@ -790,7 +790,7 @@ my %tests = (
        },
 
        'ALTER TABLE test_second_table OWNER TO' => {
-               regexp => qr/^ALTER TABLE dump_test.test_second_table OWNER TO .*;/m,
+               regexp => qr/^\QALTER TABLE dump_test.test_second_table OWNER TO \E.*;/m,
                like =>
                  { %full_runs, %dump_test_schema_runs, section_pre_data => 1, },
                unlike => {
@@ -800,7 +800,7 @@ my %tests = (
        },
 
        'ALTER TABLE measurement OWNER TO' => {
-               regexp => qr/^ALTER TABLE dump_test.measurement OWNER TO .*;/m,
+               regexp => qr/^\QALTER TABLE dump_test.measurement OWNER TO \E.*;/m,
                like =>
                  { %full_runs, %dump_test_schema_runs, section_pre_data => 1, },
                unlike => {
@@ -811,7 +811,7 @@ my %tests = (
 
        'ALTER TABLE measurement_y2006m2 OWNER TO' => {
                regexp =>
-                 qr/^ALTER TABLE dump_test_second_schema.measurement_y2006m2 OWNER TO .*;/m,
+                 qr/^\QALTER TABLE dump_test_second_schema.measurement_y2006m2 OWNER TO \E.*;/m,
                like => {
                        %full_runs,
                        role             => 1,
@@ -822,7 +822,7 @@ my %tests = (
 
        'ALTER FOREIGN TABLE foreign_table OWNER TO' => {
                regexp =>
-                 qr/^ALTER FOREIGN TABLE dump_test.foreign_table OWNER TO .*;/m,
+                 qr/^\QALTER FOREIGN TABLE dump_test.foreign_table OWNER TO \E.*;/m,
                like =>
                  { %full_runs, %dump_test_schema_runs, section_pre_data => 1, },
                unlike => {
@@ -833,7 +833,7 @@ my %tests = (
 
        'ALTER TEXT SEARCH CONFIGURATION alt_ts_conf1 OWNER TO' => {
                regexp =>
-                 qr/^ALTER TEXT SEARCH CONFIGURATION dump_test.alt_ts_conf1 OWNER TO .*;/m,
+                 qr/^\QALTER TEXT SEARCH CONFIGURATION dump_test.alt_ts_conf1 OWNER TO \E.*;/m,
                like =>
                  { %full_runs, %dump_test_schema_runs, section_pre_data => 1, },
                unlike => {
@@ -844,7 +844,7 @@ my %tests = (
 
        'ALTER TEXT SEARCH DICTIONARY alt_ts_dict1 OWNER TO' => {
                regexp =>
-                 qr/^ALTER TEXT SEARCH DICTIONARY dump_test.alt_ts_dict1 OWNER TO .*;/m,
+                 qr/^\QALTER TEXT SEARCH DICTIONARY dump_test.alt_ts_dict1 OWNER TO \E.*;/m,
                like =>
                  { %full_runs, %dump_test_schema_runs, section_pre_data => 1, },
                unlike => {
@@ -913,7 +913,7 @@ my %tests = (
                create_sql   => 'COMMENT ON TABLE dump_test.test_table
                                           IS \'comment on table\';',
                regexp =>
-                 qr/^COMMENT ON TABLE dump_test.test_table IS 'comment on table';/m,
+                 qr/^\QCOMMENT ON TABLE dump_test.test_table IS 'comment on table';\E/m,
                like => {
                        %full_runs,
                        %dump_test_schema_runs,
@@ -986,7 +986,7 @@ my %tests = (
                create_sql   => 'COMMENT ON CONVERSION dump_test.test_conversion
                                           IS \'comment on test conversion\';',
                regexp =>
-                 qr/^COMMENT ON CONVERSION dump_test.test_conversion IS 'comment on test conversion';/m,
+                 qr/^\QCOMMENT ON CONVERSION dump_test.test_conversion IS 'comment on test conversion';\E/m,
                like =>
                  { %full_runs, %dump_test_schema_runs, section_pre_data => 1, },
                unlike => { exclude_dump_test_schema => 1, },
@@ -997,7 +997,7 @@ my %tests = (
                create_sql   => 'COMMENT ON COLLATION test0
                                           IS \'comment on test0 collation\';',
                regexp =>
-                 qr/^COMMENT ON COLLATION public.test0 IS 'comment on test0 collation';/m,
+                 qr/^\QCOMMENT ON COLLATION public.test0 IS 'comment on test0 collation';\E/m,
                collation => 1,
                like      => { %full_runs, section_pre_data => 1, },
        },
@@ -1051,7 +1051,7 @@ my %tests = (
                  'COMMENT ON TEXT SEARCH CONFIGURATION dump_test.alt_ts_conf1
                                           IS \'comment on text search configuration\';',
                regexp =>
-                 qr/^COMMENT ON TEXT SEARCH CONFIGURATION dump_test.alt_ts_conf1 IS 'comment on text search configuration';/m,
+                 qr/^\QCOMMENT ON TEXT SEARCH CONFIGURATION dump_test.alt_ts_conf1 IS 'comment on text search configuration';\E/m,
                like =>
                  { %full_runs, %dump_test_schema_runs, section_pre_data => 1, },
                unlike => { exclude_dump_test_schema => 1, },
@@ -1063,7 +1063,7 @@ my %tests = (
                  'COMMENT ON TEXT SEARCH DICTIONARY dump_test.alt_ts_dict1
                                           IS \'comment on text search dictionary\';',
                regexp =>
-                 qr/^COMMENT ON TEXT SEARCH DICTIONARY dump_test.alt_ts_dict1 IS 'comment on text search dictionary';/m,
+                 qr/^\QCOMMENT ON TEXT SEARCH DICTIONARY dump_test.alt_ts_dict1 IS 'comment on text search dictionary';\E/m,
                like =>
                  { %full_runs, %dump_test_schema_runs, section_pre_data => 1, },
                unlike => { exclude_dump_test_schema => 1, },
@@ -1074,7 +1074,7 @@ my %tests = (
                create_sql   => 'COMMENT ON TEXT SEARCH PARSER dump_test.alt_ts_prs1
                                           IS \'comment on text search parser\';',
                regexp =>
-                 qr/^COMMENT ON TEXT SEARCH PARSER dump_test.alt_ts_prs1 IS 'comment on text search parser';/m,
+                 qr/^\QCOMMENT ON TEXT SEARCH PARSER dump_test.alt_ts_prs1 IS 'comment on text search parser';\E/m,
                like =>
                  { %full_runs, %dump_test_schema_runs, section_pre_data => 1, },
                unlike => { exclude_dump_test_schema => 1, },
@@ -1085,7 +1085,7 @@ my %tests = (
                create_sql => 'COMMENT ON TEXT SEARCH TEMPLATE dump_test.alt_ts_temp1
                                           IS \'comment on text search template\';',
                regexp =>
-                 qr/^COMMENT ON TEXT SEARCH TEMPLATE dump_test.alt_ts_temp1 IS 'comment on text search template';/m,
+                 qr/^\QCOMMENT ON TEXT SEARCH TEMPLATE dump_test.alt_ts_temp1 IS 'comment on text search template';\E/m,
                like =>
                  { %full_runs, %dump_test_schema_runs, section_pre_data => 1, },
                unlike => { exclude_dump_test_schema => 1, },
@@ -1096,7 +1096,7 @@ my %tests = (
                create_sql   => 'COMMENT ON TYPE dump_test.planets
                                           IS \'comment on enum type\';',
                regexp =>
-                 qr/^COMMENT ON TYPE dump_test.planets IS 'comment on enum type';/m,
+                 qr/^\QCOMMENT ON TYPE dump_test.planets IS 'comment on enum type';\E/m,
                like =>
                  { %full_runs, %dump_test_schema_runs, section_pre_data => 1, },
                unlike => { exclude_dump_test_schema => 1, },
@@ -1107,7 +1107,7 @@ my %tests = (
                create_sql   => 'COMMENT ON TYPE dump_test.textrange
                                           IS \'comment on range type\';',
                regexp =>
-                 qr/^COMMENT ON TYPE dump_test.textrange IS 'comment on range type';/m,
+                 qr/^\QCOMMENT ON TYPE dump_test.textrange IS 'comment on range type';\E/m,
                like =>
                  { %full_runs, %dump_test_schema_runs, section_pre_data => 1, },
                unlike => { exclude_dump_test_schema => 1, },
@@ -1118,7 +1118,7 @@ my %tests = (
                create_sql   => 'COMMENT ON TYPE dump_test.int42
                                           IS \'comment on regular type\';',
                regexp =>
-                 qr/^COMMENT ON TYPE dump_test.int42 IS 'comment on regular type';/m,
+                 qr/^\QCOMMENT ON TYPE dump_test.int42 IS 'comment on regular type';\E/m,
                like =>
                  { %full_runs, %dump_test_schema_runs, section_pre_data => 1, },
                unlike => { exclude_dump_test_schema => 1, },
@@ -1129,7 +1129,7 @@ my %tests = (
                create_sql   => 'COMMENT ON TYPE dump_test.undefined
                                           IS \'comment on undefined type\';',
                regexp =>
-                 qr/^COMMENT ON TYPE dump_test.undefined IS 'comment on undefined type';/m,
+                 qr/^\QCOMMENT ON TYPE dump_test.undefined IS 'comment on undefined type';\E/m,
                like =>
                  { %full_runs, %dump_test_schema_runs, section_pre_data => 1, },
                unlike => { exclude_dump_test_schema => 1, },
@@ -1282,14 +1282,14 @@ my %tests = (
 
        'INSERT INTO test_table' => {
                regexp => qr/^
-                       (?:INSERT\ INTO\ dump_test.test_table\ \(col1,\ col2,\ col3,\ col4\)\ VALUES\ \(\d,\ NULL,\ NULL,\ NULL\);\n){9}
+                       (?:INSERT\ INTO\ dump_test\.test_table\ \(col1,\ col2,\ col3,\ col4\)\ VALUES\ \(\d,\ NULL,\ NULL,\ NULL\);\n){9}
                        /xm,
                like => { column_inserts => 1, },
        },
 
        'INSERT INTO test_second_table' => {
                regexp => qr/^
-                       (?:INSERT\ INTO\ dump_test.test_second_table\ \(col1,\ col2\)
+                       (?:INSERT\ INTO\ dump_test\.test_second_table\ \(col1,\ col2\)
                           \ VALUES\ \(\d,\ '\d'\);\n){9}/xm,
                like => { column_inserts => 1, },
        },
@@ -1620,7 +1620,7 @@ my %tests = (
        'CREATE TYPE dump_test.int42' => {
                create_order => 39,
                create_sql   => 'CREATE TYPE dump_test.int42;',
-               regexp       => qr/^CREATE TYPE dump_test.int42;/m,
+               regexp       => qr/^\QCREATE TYPE dump_test.int42;\E/m,
                like =>
                  { %full_runs, %dump_test_schema_runs, section_pre_data => 1, },
                unlike => { exclude_dump_test_schema => 1, },
@@ -1832,7 +1832,7 @@ my %tests = (
        'CREATE TYPE dump_test.undefined' => {
                create_order => 39,
                create_sql   => 'CREATE TYPE dump_test.undefined;',
-               regexp       => qr/^CREATE TYPE dump_test.undefined;/m,
+               regexp       => qr/^\QCREATE TYPE dump_test.undefined;\E/m,
                like =>
                  { %full_runs, %dump_test_schema_runs, section_pre_data => 1, },
                unlike => { exclude_dump_test_schema => 1, },
@@ -2770,7 +2770,7 @@ my %tests = (
                create_sql   => 'GRANT SELECT ON TABLE dump_test.test_table
                                                   TO regress_dump_test_role;',
                regexp =>
-                 qr/^GRANT SELECT ON TABLE dump_test.test_table TO regress_dump_test_role;/m,
+                 qr/^\QGRANT SELECT ON TABLE dump_test.test_table TO regress_dump_test_role;\E/m,
                like => {
                        %full_runs,
                        %dump_test_schema_runs,
@@ -2790,7 +2790,7 @@ my %tests = (
                                                   TABLE dump_test.measurement
                                                   TO regress_dump_test_role;',
                regexp =>
-                 qr/^GRANT SELECT ON TABLE dump_test.measurement TO regress_dump_test_role;/m,
+                 qr/^\QGRANT SELECT ON TABLE dump_test.measurement TO regress_dump_test_role;\E/m,
                like =>
                  { %full_runs, %dump_test_schema_runs, section_pre_data => 1, },
                unlike => {
@@ -2805,7 +2805,7 @@ my %tests = (
                                                   TABLE dump_test_second_schema.measurement_y2006m2
                                                   TO regress_dump_test_role;',
                regexp =>
-                 qr/^GRANT SELECT ON TABLE dump_test_second_schema.measurement_y2006m2 TO regress_dump_test_role;/m,
+                 qr/^\QGRANT SELECT ON TABLE dump_test_second_schema.measurement_y2006m2 TO regress_dump_test_role;\E/m,
                like => {
                        %full_runs,
                        role             => 1,
@@ -2948,7 +2948,7 @@ my %tests = (
        },
 
        'REFRESH MATERIALIZED VIEW matview' => {
-               regexp => qr/^REFRESH MATERIALIZED VIEW dump_test.matview;/m,
+               regexp => qr/^\QREFRESH MATERIALIZED VIEW dump_test.matview;\E/m,
                like =>
                  { %full_runs, %dump_test_schema_runs, section_post_data => 1, },
                unlike => {
@@ -3015,7 +3015,7 @@ my %tests = (
                create_order => 45,
                create_sql   => 'REVOKE SELECT ON TABLE pg_proc FROM public;',
                regexp =>
-                 qr/^REVOKE SELECT ON TABLE pg_catalog.pg_proc FROM PUBLIC;/m,
+                 qr/^\QREVOKE SELECT ON TABLE pg_catalog.pg_proc FROM PUBLIC;\E/m,
                like => { %full_runs, section_pre_data => 1, },
                unlike => { no_privs => 1, },
        },