revert: Remove meaningless assignments in nbtree code

Reverts commit 05684c8255.

Reported-by: Tom Lane
Discussion: https://postgr.es/m/404.1576770942@sss.pgh.pa.us

Backpatch-through: master

diff --git a/src/backend/access/nbtree/nbtpage.c b/src/backend/access/nbtree/nbtpage.c
index 4f10ede69d1505d97e6d3a8d8eb5dcd0ca6813a5..e1a111b1ed4239e5695b56ebfab17939bf15fe94 100644 (file)
--- a/src/backend/access/nbtree/nbtpage.c
+++ b/src/backend/access/nbtree/nbtpage.c
@@ -1600,6 +1600,7 @@ _bt_mark_page_halfdead(Relation rel, Buffer leafbuf, BTStack stack)
     * fail in the field, though.
     */
    page = BufferGetPage(topparent);
+   opaque = (BTPageOpaque) PageGetSpecialPointer(page);
 
 #ifdef USE_ASSERT_CHECKING
    itemid = PageGetItemId(page, topoff);

diff --git a/src/backend/access/nbtree/nbtxlog.c b/src/backend/access/nbtree/nbtxlog.c
index 15be50642f198119802b6da536fb85785984419a..4325cbee5ba5160e685e560aeb9ed205c4b2454d 100644 (file)
--- a/src/backend/access/nbtree/nbtxlog.c
+++ b/src/backend/access/nbtree/nbtxlog.c
@@ -590,6 +590,8 @@ btree_xlog_mark_page_halfdead(uint8 info, XLogReaderState *record)
        BlockNumber rightsib;
 
        page = (Page) BufferGetPage(buffer);
+       pageop = (BTPageOpaque) PageGetSpecialPointer(page);
+
        poffset = xlrec->poffset;
 
        nextoffset = OffsetNumberNext(poffset);