During heap rebuild, lock any TOAST index until end of transaction.

swap_relation_files() calls toast_get_valid_index() to find and lock
this index, just before swapping with the rebuilt TOAST index.  The
latter function releases the lock before returning.  Potential for
mischief is low; a concurrent session can issue ALTER INDEX ... SET
(fillfactor = ...), which is not alarming.  Nonetheless, changing
pg_class.relfilenode without a lock is unconventional.  Back-patch to
9.5 (all supported versions), because another fix needs this.

Discussion: https://postgr.es/m/20191226001521.GA1772687@rfd.leadboat.com

diff --git a/src/backend/access/heap/tuptoaster.c b/src/backend/access/heap/tuptoaster.c
index cd42c50b09c8a2ac468118b83be9eb8e0348d352..52ce062c52c6264f77acbe5bfd52040ddd61c543 100644 (file)
--- a/src/backend/access/heap/tuptoaster.c
+++ b/src/backend/access/heap/tuptoaster.c
@@ -1445,8 +1445,8 @@ toast_get_valid_index(Oid toastoid, LOCKMODE lock)
    validIndexOid = RelationGetRelid(toastidxs[validIndex]);
 
    /* Close the toast relation and all its indexes */
-   toast_close_indexes(toastidxs, num_indexes, lock);
-   heap_close(toastrel, lock);
+   toast_close_indexes(toastidxs, num_indexes, NoLock);
+   heap_close(toastrel, NoLock);
 
    return validIndexOid;
 }

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 0112a87224129b4261c6ee19b937a9a6d4d409eb..0a425e1018666307d8d98823f1aa4dec277cf4be 100644 (file)
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -1652,7 +1652,7 @@ finish_heap_swap(Oid OIDOldHeap, Oid OIDNewHeap,
 
            /* Get the associated valid index to be renamed */
            toastidx = toast_get_valid_index(newrel->rd_rel->reltoastrelid,
-                                            AccessShareLock);
+                                            NoLock);
 
            /* rename the toast table ... */
            snprintf(NewToastName, NAMEDATALEN, "pg_toast_%u",