Remove some useless free calls.

These were introduced in recent commit 52e4f0cd47. We were trying to free
some transient space consumption and that too was not entirely correct and
complete. We don't need this partial freeing of memory as it will be
allocated just once for a query and will be freed at the end of the query.

Author: Zhihong Yu
Reviewed-by: Amit Kapila
Discussion: https://postgr.es/m/CALNJ-vQORfQ=vicbKA_RmeGZGzm1y3WsEcZqXWi7qjN43Cz_vg@mail.gmail.com

diff --git a/src/backend/commands/publicationcmds.c b/src/backend/commands/publicationcmds.c
index f890d3f0baadabafe62d7982ca66f6e2ef9a98fb..c6437799c53bb253a69b3da6bbda4e9f426179ac 100644 (file)
--- a/src/backend/commands/publicationcmds.c
+++ b/src/backend/commands/publicationcmds.c
@@ -409,9 +409,6 @@ contain_invalid_rfcolumn(Oid pubid, Relation relation, List *ancestors,
        context.bms_replident = bms;
        rfnode = stringToNode(TextDatumGetCString(rfdatum));
        result = contain_invalid_rfcolumn_walker(rfnode, &context);
-
-       bms_free(bms);
-       pfree(rfnode);
    }
 
    ReleaseSysCache(rftuple);
@@ -1182,9 +1179,6 @@ AlterPublicationTables(AlterPublicationStmt *stmt, HeapTuple tup,
                }
            }
 
-           if (oldrelwhereclause)
-               pfree(oldrelwhereclause);
-
            /*
             * Add the non-matched relations to a list so that they can be
             * dropped.