Correct reference to pg_catalog.regtype in pg_upgrade query
authorTomas Vondra <tomas.vondra@postgresql.org>
Mon, 14 Oct 2019 22:25:04 +0000 (00:25 +0200)
committerTomas Vondra <tomas.vondra@postgresql.org>
Mon, 14 Oct 2019 22:25:04 +0000 (00:25 +0200)
The recursive CTE added in 0ccfc28223 referenced pg_catalog.regtype,
without the schema part, unlike all other queries in pg_upgrade.

Backpatch-to: 12
src/bin/pg_upgrade/version.c

index f3fd8fa27378f275fcc7533e31a525ee7b646aea..8375a46454afdcc1c363708bee8dcb5ba7f02ef7 100644 (file)
@@ -443,7 +443,7 @@ old_11_check_for_sql_identifier_data_type_usage(ClusterInfo *cluster)
        res = executeQueryOrDie(conn,
                                "WITH RECURSIVE oids AS ( "
        /* the sql_identifier type itself */
-                               "   SELECT 'information_schema.sql_identifier'::regtype AS oid "
+                               "   SELECT 'information_schema.sql_identifier'::pg_catalog.regtype AS oid "
                                "   UNION ALL "
                                "   SELECT * FROM ( "
        /* domains on the type */