Don't treat DumpOptions->dump_inserts like a boolean
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Wed, 8 Jul 2020 18:52:39 +0000 (14:52 -0400)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Wed, 8 Jul 2020 18:54:46 +0000 (14:54 -0400)
This has been an integer count since 7e413a0f82c8 so treat it explicitly
like an integer.

No backpatch since this is just cosmetic.

src/bin/pg_dump/pg_backup.h
src/bin/pg_dump/pg_dump.c

index 8c0cedcd983efc467abf7440da6bd75be23ed515..b17c9dbb8beb6ca0bc9ccc36a4cdfa0c75007c1c 100644 (file)
@@ -71,7 +71,7 @@ typedef struct _restoreOptions
    char       *use_role;       /* Issue SET ROLE to this */
    int         dropSchema;
    int         disable_dollar_quoting;
-   int         dump_inserts;
+   int         dump_inserts;   /* 0 = COPY, otherwise rows per INSERT */
    int         column_inserts;
    int         if_exists;
    int         no_comments;    /* Skip comments */
index c2627bb630b7f0c2117d22d6367e282a776fd71e..45946eec46399ac9388fecd63cdaec0f7dd8fcf1 100644 (file)
@@ -2254,7 +2254,7 @@ dumpTableData(Archive *fout, TableDataInfo *tdinfo)
    char       *copyStmt;
    const char *copyFrom;
 
-   if (!dopt->dump_inserts)
+   if (dopt->dump_inserts == 0)
    {
        /* Dump/restore using COPY */
        dumpFn = dumpTableData_copy;