Avoid use of Perl getprotobyname

getprotobyname returns undefined on some CI machines.  It's not clear
why.  The code overall still works, but it raises a warning.

In PostgreSQL C code, we always call socket() with 0 for the protocol
argument, so we should be able to do the same in Perl (since the Perl
documentation says that the arguments of the socket function are the
same as in C).  So do that, to avoid the issue.

Reviewed-by: Andrew Dunstan <andrew@dunslane.net>
Discussion: https://www.postgresql.org/message-id/flat/06f899fd-1826-05ab-42d6-adeb1fd5e200%40eisentraut.org

diff --git a/src/test/perl/PostgreSQL/Test/Cluster.pm b/src/test/perl/PostgreSQL/Test/Cluster.pm
index 5e161dbee60758f5a1935829289bbd6ded877ab4..41409ba1bed5802188fd39bbebaf90bdb7d6cba5 100644 (file)
--- a/src/test/perl/PostgreSQL/Test/Cluster.pm
+++ b/src/test/perl/PostgreSQL/Test/Cluster.pm
@@ -1570,9 +1570,8 @@ sub can_bind
    my ($host, $port) = @_;
    my $iaddr = inet_aton($host);
    my $paddr = sockaddr_in($port, $iaddr);
-   my $proto = getprotobyname("tcp");
 
-   socket(SOCK, PF_INET, SOCK_STREAM, $proto)
+   socket(SOCK, PF_INET, SOCK_STREAM, 0)
      or die "socket failed: $!";
 
    # As in postmaster, don't use SO_REUSEADDR on Windows