Choose FK name correctly during partition attachment
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Thu, 8 Sep 2022 11:17:02 +0000 (13:17 +0200)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Thu, 8 Sep 2022 11:17:02 +0000 (13:17 +0200)
commite7936f8b3e57046c0e178ccefa04ac7e6fbae79c
tree92df8dea495bd37f8c7bdbe790957051a28d6f7e
parentadb466150b44d1eaf43a2d22f58ff4c545a0ed3f
Choose FK name correctly during partition attachment

During ALTER TABLE ATTACH PARTITION, if the name of a parent's foreign
key constraint is already used on the partition, the code tries to
choose another one before the FK attributes list has been populated,
so the resulting constraint name was "<relname>__fkey" instead of
"<relname>_<attrs>_fkey".  Repair, and add a test case.

Backpatch to 12.  In 11, the code to attach a partition was not smart
enough to cope with conflicting constraint names, so the problem doesn't
exist there.

Author: Jehan-Guillaume de Rorthais <jgdr@dalibo.com>
Discussion: https://postgr.es/m/20220901184156.738ebee5@karst
src/backend/commands/tablecmds.c
src/test/regress/expected/constraints.out
src/test/regress/sql/constraints.sql