Reword recent error messages: "should" -> "must"
authorÁlvaro Herrera <alvherre@alvh.no-ip.org>
Tue, 21 Jan 2025 14:24:49 +0000 (15:24 +0100)
committerÁlvaro Herrera <alvherre@alvh.no-ip.org>
Tue, 21 Jan 2025 14:24:49 +0000 (15:24 +0100)
commitdb19a5061ce954320f47a65c169081cbb2d920f8
tree5bc3f00b96294f00d53a8481fdffa4c61d5a81b7
parent9b21f203dd879a6a7eb3b8629f3d8cae0c1381a5
Reword recent error messages: "should" -> "must"

Most were introduced in the 17 timeframe.  The ones in wparser_def.c are
very old.

I also changed "JSON path expression for column \"%s\" should return
single item without wrapper" to "JSON path expression for column \"%s\"
must return single item when no wrapper is requested" to avoid
ambiguity.

Backpatch to 17.

Crickets: https://postgr.es/m/202501131819.26ors7oouafu@alvherre.pgsql
src/backend/tsearch/wparser_def.c
src/backend/utils/adt/jsonpath_exec.c
src/test/regress/expected/sqljson_jsontable.out
src/test/regress/expected/sqljson_queryfuncs.out