Add a test module for the regular expression package.
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 6 Jan 2021 15:51:14 +0000 (10:51 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 6 Jan 2021 15:51:14 +0000 (10:51 -0500)
commitca8217c10138fa3ffe1e7d1def2484fd0eb78226
tree65e42fc9ad482246780e2dc1abadb502c68cf517
parent4656e3d66893f286767285cf74dabb3877068e49
Add a test module for the regular expression package.

This module provides a function test_regex() that is functionally
rather like regexp_matches(), but with additional debugging-oriented
options and additional output.  The debug options are somewhat obscure;
they are chosen to match the API of the test harness that Henry Spencer
wrote way-back-when for use in Tcl.  With this, we can import all the
test cases that Spencer wrote originally, even for regex functionality
that we don't currently expose in Postgres.  This seems necessary
because we can no longer rely on Tcl to act as upstream and verify
any fixes or improvements that we make.

In addition to Spencer's tests, I added a few for lookbehind
constraints (which we added in 2015, and Tcl still hasn't absorbed)
that are modeled on his tests for lookahead constraints.  After looking
at code coverage reports, I also threw in a couple of tests to more
fully exercise our "high colormap" logic.

According to my testing, this brings the check-world coverage
for src/backend/regex/ from 71.1% to 86.7% of lines.
(coverage.postgresql.org shows a slightly different number,
which I think is because it measures a non-assert build.)

Discussion: https://postgr.es/m/2873268.1609732164@sss.pgh.pa.us
12 files changed:
src/test/modules/Makefile
src/test/modules/test_regex/.gitignore [new file with mode: 0644]
src/test/modules/test_regex/Makefile [new file with mode: 0644]
src/test/modules/test_regex/README [new file with mode: 0644]
src/test/modules/test_regex/expected/test_regex.out [new file with mode: 0644]
src/test/modules/test_regex/expected/test_regex_utf8.out [new file with mode: 0644]
src/test/modules/test_regex/expected/test_regex_utf8_1.out [new file with mode: 0644]
src/test/modules/test_regex/sql/test_regex.sql [new file with mode: 0644]
src/test/modules/test_regex/sql/test_regex_utf8.sql [new file with mode: 0644]
src/test/modules/test_regex/test_regex--1.0.sql [new file with mode: 0644]
src/test/modules/test_regex/test_regex.c [new file with mode: 0644]
src/test/modules/test_regex/test_regex.control [new file with mode: 0644]