Repair breakage of aggregate FILTER option.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 16 Oct 2017 19:24:36 +0000 (15:24 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 16 Oct 2017 19:24:36 +0000 (15:24 -0400)
commitc3dfe0fec01469b8a7de327303cad50ba8ed338a
tree3e182ddc3e868a6e07ab90a472b50ce7d1d71687
parent60a1d96ed7ba0930024af696e1fb209a030b6c42
Repair breakage of aggregate FILTER option.

An aggregate's input expression(s) are not supposed to be evaluated
at all for a row where its FILTER test fails ... but commit 8ed3f11bb
overlooked that requirement.  Reshuffle so that aggregates having a
filter clause evaluate their arguments separately from those without.
This still gets the benefit of doing only one ExecProject in the
common case of multiple Aggrefs, none of which have filters.

While at it, arrange for filter clauses to be included in the common
ExecProject evaluation, thus perhaps buying a little bit even when
there are filters.

Back-patch to v10 where the bug was introduced.

Discussion: https://postgr.es/m/30065.1508161354@sss.pgh.pa.us
src/backend/executor/nodeAgg.c
src/include/nodes/execnodes.h
src/test/regress/expected/aggregates.out
src/test/regress/sql/aggregates.sql