createdb: Fix quoting of --encoding, --lc-ctype and --lc-collate
authorMichael Paquier <michael@paquier.xyz>
Thu, 27 Feb 2020 02:21:07 +0000 (11:21 +0900)
committerMichael Paquier <michael@paquier.xyz>
Thu, 27 Feb 2020 02:21:07 +0000 (11:21 +0900)
commit83bd732eb2c83a26db9eefb4595615fa289620a8
treeae6f3d4627036c7cf47d4efd7fa5823fd44aa04f
parent143152439dc9482b1ae983f2819453e7300eca7f
createdb: Fix quoting of --encoding, --lc-ctype and --lc-collate

The original coding failed to properly quote those arguments, leading to
failures when using quotes in the values used.  As the quoting can be
encoding-sensitive, the connection to the backend needs to be taken
before applying the correct quoting.

Author: Michael Paquier
Reviewed-by: Daniel Gustafsson
Discussion: https://postgr.es/m/20200214041004.GB1998@paquier.xyz
Backpatch-through: 9.5
src/bin/scripts/createdb.c
src/bin/scripts/t/020_createdb.pl