Improve more comments in astreamer_gzip.c.
authorRobert Haas <rhaas@postgresql.org>
Fri, 16 Aug 2024 17:34:18 +0000 (13:34 -0400)
committerRobert Haas <rhaas@postgresql.org>
Fri, 16 Aug 2024 17:45:23 +0000 (13:45 -0400)
commit76dd015e859845fc5fe60557328e3a6bbf11be31
tree3a6889972746f90a2a4379adf892db3fa6c90cd4
parentb8b3f861fbd7ff40055225ec48cec97df925ff04
Improve more comments in astreamer_gzip.c.

Duplicate the comment from astreamer_plain_writer_new instead of just
referring to it. Add a further note to mention that there are dangers
if anything else is written to the same FILE. Also add a comment where
we dup() the filehandle, referring to the existing comment in
astreamer_gzip_writer_finalize(), because the dup() looks wrong on
first glance without that comment to clarify.

Per concerns expressed by Tom Lane on pgsql-security, and using
some wording suggested by him.

Discussion: http://postgr.es/m/CA+TgmoYTFAD0YTh4HC1Nuhn0YEyoQi0_CENFgVzAY_YReiSksQ@mail.gmail.com
src/fe_utils/astreamer_gzip.c