pg_dump test: Make concatenated create_sql commands more readable
authorPeter Eisentraut <peter@eisentraut.org>
Mon, 31 Oct 2022 12:59:57 +0000 (13:59 +0100)
committerPeter Eisentraut <peter@eisentraut.org>
Mon, 31 Oct 2022 13:19:08 +0000 (14:19 +0100)
commit6e10631d1e6e350ba3f82b0bd3a29678f9f5badd
tree8a7d33178d0666c2938eff9ac4cd8706b8a71281
parenta73952b795632b2cf5acada8476e7cf75857e9be
pg_dump test: Make concatenated create_sql commands more readable

When the pg_dump 002_pg_dump.pl test generates the command to load the
schema, it does

    # Add terminating semicolon
    $create_sql{$test_db} .= $tests{$test}->{create_sql} . ";";

In some cases, this creates a duplicate semicolon, but more
importantly, this doesn't add any newline.  So if you look at the
result in either the server log or in
tmp_check/log/regress_log_002_pg_dump, it looks like a complete mess.
This patch makes the output look cleaner for manual inspection: add
semicolon only if necessary, and add two newlines.

Discussion: https://www.postgresql.org/message-id/flat/d6aec95a-8729-43cc-2578-f2a5e46640e0%40enterprisedb.com
src/bin/pg_dump/t/002_pg_dump.pl