Unpin buffer before inplace update waits for an XID to end.
authorNoah Misch <noah@leadboat.com>
Tue, 29 Oct 2024 16:39:55 +0000 (09:39 -0700)
committerNoah Misch <noah@leadboat.com>
Tue, 29 Oct 2024 16:39:55 +0000 (09:39 -0700)
commit30d47ec8c6c78f46bcd7116b7effb6988b126e43
tree6923495c5c6d211a84d4edda9219eb649c0d6ac4
parent502e7bf7f09c458ce66ce043b94864b535c5d5d0
Unpin buffer before inplace update waits for an XID to end.

Commit a07e03fd8fa7daf4d1356f7cb501ffe784ea6257 changed inplace updates
to wait for heap_update() commands like GRANT TABLE and GRANT DATABASE.
By keeping the pin during that wait, a sequence of autovacuum workers
and an uncommitted GRANT starved one foreground LockBufferForCleanup()
for six minutes, on buildfarm member sarus.  Prevent, at the cost of a
bit of complexity.  Back-patch to v12, like the earlier commit.  That
commit and heap_inplace_lock() have not yet appeared in any release.

Discussion: https://postgr.es/m/20241026184936.ae.nmisch@google.com
src/backend/access/heap/heapam.c
src/backend/access/index/genam.c
src/include/access/heapam.h