Fix heap_getattr() handling of fast defaults.
authorAndres Freund <andres@anarazel.de>
Wed, 6 Feb 2019 09:09:32 +0000 (01:09 -0800)
committerAndres Freund <andres@anarazel.de>
Wed, 6 Feb 2019 09:09:32 +0000 (01:09 -0800)
commit171e0418b03dc103d5d9bdc0bfaadbb193dd7fd6
treeff26943d0315fe748706952a9678eaeaf2ad86a5
parentd07fb6810e51a676c4c631f673b8da09f63205b3
Fix heap_getattr() handling of fast defaults.

Previously heap_getattr() returned NULL for attributes with a fast
default value (c.f. 16828d5c0273), as it had no handling whatsoever
for that case.

A previous fix, 7636e5c60f, attempted to fix issues caused by this
oversight, but just expanding OLD tuples for triggers doesn't actually
solve the underlying issue.

One known consequence of this bug is that the check for HOT updates
can return the wrong result, when a previously fast-default'ed column
is set to NULL. Which in turn means that an index over a column with
fast default'ed columns might be corrupt if the underlying column(s)
allow NULLs.

Fix by handling fast default columns in heap_getattr(), remove now
superfluous expansion in GetTupleForTrigger().

Author: Andres Freund
Discussion: https://postgr.es/m/20190201162404.onngi77f26baem4g@alap3.anarazel.de
Backpatch: 11, where fast defaults were introduced
src/backend/access/common/heaptuple.c
src/backend/commands/trigger.c
src/include/access/htup_details.h
src/test/regress/expected/fast_default.out
src/test/regress/sql/fast_default.sql