fix: improve prefix detection #3238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yajra
approved these changes
May 9, 2025
There was a problem hiding this comment.
It would be nice if we can have unit tests for this cases. Will also try to implement when I get the chance.
Good to go as tested by @tkcsdemos
|
Released on https://github.com/yajra/laravel-datatables/releases/tag/v12.2.1 🚀 Thanks @Seb33300 and @tkcsdemos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3237
In the previous implementation, I was looking only for prefixed columns.
Unfortunately, this was not working as expected when custom select without alias were manually added.
I have refactored to try to retrieve the table prefix by searching in all selected columns even if they do not have an alias.