Skip to content

Commit c4eae77

Browse files
committed
Polish
1 parent ebd93d8 commit c4eae77

File tree

6 files changed

+17
-39
lines changed

6 files changed

+17
-39
lines changed
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
11
package com.example
22

3+
import org.reactivestreams.Publisher
34
import org.springframework.data.repository.reactive.ReactiveCrudRepository
45
import reactor.core.publisher.Mono
56

6-
fun <S : T, T, ID> ReactiveCrudRepository<T, ID>.save(entity: Mono<S?>): Mono<S> {
7+
fun <S : T, T, ID> ReactiveCrudRepository<T, ID>.save(entity: Publisher<S>): Mono<S> {
78
return Mono.from<S>(entity).flatMap { this.save(it) }
89
}
910

10-
fun <S : T, T, ID> ReactiveCrudRepository<T, ID>.delete(entity: Mono<S>): Mono<Void> {
11+
fun <S : T, T, ID> ReactiveCrudRepository<T, ID>.delete(entity: Publisher<S>): Mono<Void> {
1112
return Mono.from<S>(entity).flatMap { this.delete(it) }
1213
}

r2dbc/src/main/kotlin/com/example/message/MessageService.kt

+2-1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import org.springframework.stereotype.Service
66
import org.springframework.transaction.annotation.Transactional
77
import reactor.core.publisher.Flux
88
import reactor.core.publisher.Mono
9+
import reactor.kotlin.core.publisher.toMono
910

1011
@Service
1112
@Transactional(readOnly = true)
@@ -20,7 +21,7 @@ class MessageService(private val messageRepository: MessageRepository, private v
2021
}
2122

2223
@Transactional
23-
fun save(message: Message): Mono<Message> = messageRepository.save(Mono.just(message))
24+
fun save(message: Message): Mono<Message> = messageRepository.save(message.toMono())
2425

2526
@Transactional
2627
fun delete(id: Long): Mono<Void> = messageRepository.deleteById(id)

r2dbc/src/test/kotlin/com/example/message/MessageTest.kt

-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import com.example.account.AccountRepository
55
import org.assertj.core.api.Assertions.assertThat
66
import org.junit.jupiter.api.Test
77
import org.springframework.beans.factory.annotation.Autowired
8-
import org.springframework.boot.test.autoconfigure.data.mongo.DataMongoTest
98
import org.springframework.boot.test.autoconfigure.data.r2dbc.DataR2dbcTest
109
import reactor.core.publisher.Mono
1110
import reactor.kotlin.test.test

web/src/test/kotlin/com/example/WebApplicationTests.kt

-16
This file was deleted.

webflux/src/test/kotlin/com/example/WebfluxApplicationTests.kt

-13
This file was deleted.

webflux/src/test/kotlin/com/example/message/MessageControllerTests.kt

+12-6
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import org.assertj.core.api.Assertions.assertThat
77
import org.junit.jupiter.api.Test
88
import org.mockito.BDDMockito.anyString
99
import org.mockito.BDDMockito.given
10-
import org.mockito.Mockito
1110
import org.mockito.Mockito.atLeastOnce
1211
import org.mockito.Mockito.verify
1312
import org.springframework.beans.factory.annotation.Autowired
@@ -18,8 +17,9 @@ import org.springframework.http.MediaType
1817
import org.springframework.security.test.web.reactive.server.SecurityMockServerConfigurers.csrf
1918
import org.springframework.test.web.reactive.server.WebTestClient
2019
import org.springframework.test.web.reactive.server.expectBody
21-
import reactor.core.publisher.Flux
2220
import reactor.core.publisher.Mono
21+
import reactor.kotlin.core.publisher.toFlux
22+
import reactor.kotlin.core.publisher.toMono
2323

2424
@WebFluxTest(MessageController::class)
2525
@MockUser
@@ -32,7 +32,9 @@ internal class MessageControllerTests(@Autowired private val webTestClient: WebT
3232
@Test
3333
internal fun `message all test`() {
3434

35-
given(messageService.findAll()).willReturn(Flux.just(Message(id = "foo", message = "test message", account = Account("wonwoo", "foo"))))
35+
given(messageService.findAll()).willReturn(
36+
listOf(Message(id = "foo", message = "test message", account = Account("wonwoo", "foo"))).toFlux()
37+
)
3638

3739
webTestClient.get()
3840
.uri("/message")
@@ -54,8 +56,10 @@ internal class MessageControllerTests(@Autowired private val webTestClient: WebT
5456
internal fun `message save test`() {
5557

5658
val message = Message(message = "test message", account = Account(id = "bar", name = "user", passwd = "password"))
57-
given(messageService.findAll()).willReturn(Flux.just(Message(id = "foo", message = "test message", account = Account("wonwoo", "foo"))))
58-
given(messageService.save(message)).willReturn(Mono.just(message))
59+
given(messageService.findAll()).willReturn(
60+
listOf(Message(id = "foo", message = "test message", account = Account("wonwoo", "foo"))).toFlux()
61+
)
62+
given(messageService.save(message)).willReturn(message.toMono())
5963

6064

6165
webTestClient.mutateWith(csrf())
@@ -84,7 +88,9 @@ internal class MessageControllerTests(@Autowired private val webTestClient: WebT
8488
internal fun `message delete test`() {
8589

8690
given(messageService.delete(anyString())).willReturn(Mono.empty())
87-
given(messageService.findAll()).willReturn(Flux.just(Message(id = "foo", message = "test message", account = Account("wonwoo", "foo"))))
91+
given(messageService.findAll()).willReturn(
92+
listOf(Message(id = "foo", message = "test message", account = Account("wonwoo", "foo"))).toFlux()
93+
)
8894

8995
webTestClient.mutateWith(csrf())
9096
.post()

0 commit comments

Comments
 (0)