Skip to content

fix(compat): ensure false value on input value retains attribute #13216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

edison1105
Copy link
Member

close #13205

@edison1105 edison1105 changed the title fix(compat): ensure false value on input retains value attribute fix(compat): ensure false value on input value retains attribute Apr 17, 2025
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 38.1 kB 34.4 kB
vue.global.prod.js 158 kB 58.3 kB 51.9 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.4 kB 18.1 kB 16.6 kB
createApp 54.4 kB 21.2 kB 19.4 kB
createSSRApp 58.6 kB 22.9 kB 20.9 kB
defineCustomElement 59.2 kB 22.7 kB 20.7 kB
overall 68.5 kB 26.3 kB 24 kB

Copy link

pkg-pr-new bot commented Apr 17, 2025

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13216

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13216

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13216

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13216

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13216

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13216

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13216

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13216

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13216

vue

npm i https://pkg.pr.new/vue@13216

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13216

commit: 50795f7

@edison1105 edison1105 marked this pull request as ready for review April 17, 2025 07:59
@edison1105 edison1105 added ready to merge The PR is ready to be merged. 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. scope: v2 compat labels Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready to merge The PR is ready to be merged. scope: v2 compat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compat: ATTR_FALSE_VALUE incorrectly removes value attribute on inputs
1 participant