Skip to content

fix(compiler-core): remove slot cache from parent renderCache during unmounting #13215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Apr 17, 2025

Copy link

github-actions bot commented Apr 17, 2025

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 101 kB (+70 B) 38.2 kB (+31 B) 34.4 kB (+16 B)
vue.global.prod.js 159 kB (+384 B) 58.3 kB (+80 B) 51.9 kB (+91 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.5 kB (+70 B) 18.2 kB (+28 B) 16.6 kB (+26 B)
createApp 54.5 kB (+70 B) 21.2 kB (+26 B) 19.4 kB (+28 B)
createSSRApp 58.7 kB (+70 B) 22.9 kB (+33 B) 20.9 kB (+54 B)
defineCustomElement 59.3 kB (+70 B) 22.7 kB (+28 B) 20.8 kB (+26 B)
overall 68.5 kB (+70 B) 26.4 kB (+26 B) 24 kB (+29 B)

Copy link

pkg-pr-new bot commented Apr 17, 2025

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13215

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13215

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13215

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13215

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13215

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13215

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13215

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13215

vue

npm i https://pkg.pr.new/vue@13215

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13215

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13215

commit: 68b6b78

@edison1105 edison1105 force-pushed the edison/fix/slotCache branch 2 times, most recently from 740951f to f675097 Compare April 17, 2025 06:47
@edison1105 edison1105 added ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. ready to merge The PR is ready to be merged. scope: compiler labels Apr 17, 2025
@edison1105 edison1105 force-pushed the edison/fix/slotCache branch from f675097 to d5d7904 Compare April 17, 2025 07:04
@edison1105 edison1105 force-pushed the edison/fix/slotCache branch from d5d7904 to 371edbe Compare April 17, 2025 07:10
@edison1105
Copy link
Member Author

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Apr 18, 2025

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools success success
radix-vue success success
test-utils success success
vuetify success success
vue-i18n success success
primevue success success
quasar success success
nuxt success success
router success success
vue-simple-compiler success success
vueuse success success
vitepress success success
vue-macros success success
vant success success
vite-plugin-vue success success
pinia success success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. ready to merge The PR is ready to be merged. scope: compiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detached elements due to cached static vnodes
2 participants