Skip to content

feat(runtime-vapor): support HMR for setup function #13102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: vapor
Choose a base branch
from

Conversation

zhiyuanzmj
Copy link
Member

@zhiyuanzmj zhiyuanzmj commented Mar 25, 2025

For tsx we use setup to expose DOM, non render function.
So can we add HMR support for setup function and functional component?

defineComponent({
  setup() {
    return <div />
  }
})

// or functional component
const Comp = () => {
  return <div />
}

Copy link

netlify bot commented Mar 25, 2025

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit f264ceb
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/67e21923bea2ff0008d0cbae
😎 Deploy Preview https://deploy-preview-13102--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zhiyuanzmj zhiyuanzmj changed the title feat(runtime-vapor): support HMR for setup feat(runtime-vapor): support HMR for setup function Mar 25, 2025
Copy link

pkg-pr-new bot commented Mar 25, 2025

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13102

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13102

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13102

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13102

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@13102

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13102

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13102

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13102

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@13102

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13102

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13102

vue

npm i https://pkg.pr.new/vue@13102

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13102

commit: f264ceb

@edison1105 edison1105 added the scope: vapor related to vapor mode label Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: vapor related to vapor mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants