Merge pull request operator-framework#61 from ContainerSolutions/delete_improvements

improving on corner case situation on delete event scheduling

Author: csviri

operator-framework/src/main/java/com/github/containersolutions/operator/processing/EventScheduler.java

@@ -75,6 +75,14 @@ void scheduleEvent(CustomResourceEvent event) {
         log.debug("Scheduling event: {}", event);
         try {
             lock.lock();
+            if (event.getResource().getMetadata().getDeletionTimestamp() != null && event.getAction() == Action.DELETED) {
+                // Note that we always use finalizers, we want to process delete event just in corner case,
+                // when we are not able to add finalizer (lets say because of optimistic locking error, and the resource was deleted instantly).
+                // We want to skip in case of finalizer was there since we don't want to execute delete method always at least 2x,
+                // which would be the result if we don't skip here. (If there is no deletion timestamp if resource deleted without finalizer.
+                log.debug("Skipping delete event since deletion timestamp is present on resource, so finalizer was in place.");
+                return;
+            }
             if (eventStore.receivedMoreRecentEventBefore(event)) {
                 log.debug("Skipping event processing since was processed event with newer version before. {}", event);
                 return;