Naming changes in CMakeLists.txt files

Author: LimHyungTae

cpp/CMakeLists.txt

@@ -1,11 +1,10 @@
 cmake_minimum_required(VERSION 3.11)
-project(PATCHWORK VERSION 1.0.0)
+project(patchworkpp VERSION 1.0.0)
 
 set(CMAKE_CXX_STANDARD 20)
 set(PYTHON_EXECUTABLE python3)
 set(CMAKE_BUILD_TYPE Release)
 
-
 set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${Open3D_C_FLAGS}")
 set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${Open3D_CXX_FLAGS}")
 set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} ${Open3D_EXE_LINKER_FLAGS}")
@@ -17,30 +16,37 @@ else()
   list(PREPEND CMAKE_MODULE_PATH ${CMAKE_CURRENT_SOURCE_DIR}/cmake)
 endif()
 
+option(BUILD_CPP_EXAMPLES "Build C++ example codes, which require Open3D for visualization" OFF)
 
-list(APPEND Open3D_LIBRARIES dl)
+# Parameters in `patchworkpp` subdirectory.
+# Thus, link should be `patchworkpp::ground_seg_cores`
+set(PARENT_PROJECT_NAME ${PROJECT_NAME})
+set(TARGET_NAME ground_seg_cores)
 
 add_subdirectory(patchworkpp)
 
-set(INCLUDE_EXAMPLES ON CACHE BOOL "Build examples")
+if (BUILD_CPP_EXAMPLES)
+  list(APPEND Open3D_LIBRARIES dl)
+  set(INCLUDE_EXAMPLES ON CACHE BOOL "Build examples")
 
-if (INCLUDE_EXAMPLES)
+  if (INCLUDE_EXAMPLES)
 
-  message(STATUS "Building examples for c++")
-  find_package(Open3D REQUIRED HINTS ${CMAKE_INSTALL_PREFIX}/lib/CMake)
+    message(STATUS "Building examples for c++")
+    find_package(Open3D REQUIRED HINTS ${CMAKE_INSTALL_PREFIX}/lib/CMake)
 
-  list(APPEND Open3D_LIBRARIES dl)
-  link_directories(${Open3D_LIBRARY_DIRS})
-  message(STATUS "Found Open3D ${Open3D_VERSION}")
+    list(APPEND Open3D_LIBRARIES dl)
+    link_directories(${Open3D_LIBRARY_DIRS})
+    message(STATUS "Found Open3D ${Open3D_VERSION}")
 
-  add_executable(demo_visualize ${CMAKE_CURRENT_SOURCE_DIR}/patchworkpp/examples/demo_visualize.cpp)
-  target_link_libraries(demo_visualize PRIVATE PATCHWORK::patchworkpp ${Open3D_LIBRARIES} "stdc++fs")
-  target_include_directories(demo_visualize PUBLIC ${Open3D_INCLUDE_DIRS})
-  set_target_properties(demo_visualize PROPERTIES RUNTIME_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/examples")
+    add_executable(demo_visualize ${CMAKE_CURRENT_SOURCE_DIR}/patchworkpp/examples/demo_visualize.cpp)
+    target_link_libraries(demo_visualize PRIVATE ${PARENT_PROJECT_NAME}::${TARGET_NAME} ${Open3D_LIBRARIES} "stdc++fs")
+    target_include_directories(demo_visualize PUBLIC ${Open3D_INCLUDE_DIRS})
+    set_target_properties(demo_visualize PROPERTIES RUNTIME_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/examples")
 
-  add_executable(demo_sequential ${CMAKE_CURRENT_SOURCE_DIR}/patchworkpp/examples/demo_sequential.cpp)
-  target_link_libraries(demo_sequential PRIVATE PATCHWORK::patchworkpp ${Open3D_LIBRARIES} "stdc++fs")
-  target_include_directories(demo_sequential PUBLIC ${Open3D_INCLUDE_DIRS})
-  set_target_properties(demo_sequential PROPERTIES RUNTIME_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/examples")
+    add_executable(demo_sequential ${CMAKE_CURRENT_SOURCE_DIR}/patchworkpp/examples/demo_sequential.cpp)
+    target_link_libraries(demo_sequential PRIVATE ${PARENT_PROJECT_NAME}::${TARGET_NAME} ${Open3D_LIBRARIES} "stdc++fs")
+    target_include_directories(demo_sequential PUBLIC ${Open3D_INCLUDE_DIRS})
+    set_target_properties(demo_sequential PROPERTIES RUNTIME_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/examples")
 
-endif()
+  endif()
+endif()

cpp/patchworkpp/CMakeLists.txt

@@ -2,32 +2,34 @@ project(patchworkpp_src)
 
 include(GNUInstallDirs)
 
+message("Parent project name: " ${PARENT_PROJECT_NAME})
+
 find_package(Eigen3 REQUIRED QUIET)
 
-add_library(patchworkpp STATIC src/patchworkpp.cpp)
-set_target_properties(patchworkpp PROPERTIES POSITION_INDEPENDENT_CODE ON)
+add_library(${TARGET_NAME} STATIC src/patchworkpp.cpp)
+set_target_properties(${TARGET_NAME} PROPERTIES POSITION_INDEPENDENT_CODE ON)
 
-target_include_directories(patchworkpp PUBLIC
+target_include_directories(${TARGET_NAME} PUBLIC
   $<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/include>
   $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
   $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>
 )
-target_link_libraries(patchworkpp Eigen3::Eigen)
-add_library(PATCHWORK::patchworkpp ALIAS patchworkpp)
+target_link_libraries(${TARGET_NAME} Eigen3::Eigen)
+add_library(${PARENT_PROJECT_NAME}::${TARGET_NAME} ALIAS ${TARGET_NAME})
 
 install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/include/
   DESTINATION include
 )
-install(TARGETS patchworkpp
-  EXPORT PATCHWORKConfig
+install(TARGETS ${TARGET_NAME}
+  EXPORT ${PARENT_PROJECT_NAME}Config
   LIBRARY DESTINATION lib
 )
 
-export(TARGETS patchworkpp
-  NAMESPACE PATCHWORK::
-  FILE "${CMAKE_CURRENT_BINARY_DIR}/PATCHWORKConfig.cmake"
+export(TARGETS ${TARGET_NAME}
+  NAMESPACE ${PARENT_PROJECT_NAME}::
+  FILE "${CMAKE_CURRENT_BINARY_DIR}/${PARENT_PROJECT_NAME}Config.cmake"
 )
-install(EXPORT PATCHWORKConfig
-  DESTINATION "${CMAKE_INSTALL_DATADIR}/PATCHWORK/cmake"
-  NAMESPACE PATCHWORK::
+install(EXPORT ${PARENT_PROJECT_NAME}Config
+  DESTINATION "${CMAKE_INSTALL_DATADIR}/${PARENT_PROJECT_NAME}/cmake"
+  NAMESPACE ${PARENT_PROJECT_NAME}::
 )

python/CMakeLists.txt

@@ -6,6 +6,12 @@ set(CMAKE_BUILD_TYPE Release)
 set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
 set(CMAKE_POSITION_INDEPENDENT_CODE ON)
 
+# Parameters used in `patchworkpp` subdirectory.
+# Thus, link should be `patchworkpp::ground_seg_cores`
+# See https://github.com/url-kaist/patchwork-plusplus/tree/master/cpp/CMakeLists.txt#L21
+set(PARENT_PROJECT_NAME patchworkpp)
+set(TARGET_NAME ground_seg_cores)
+
 find_package(Python COMPONENTS Interpreter Development.Module REQUIRED)
 find_package(pybind11 CONFIG REQUIRED)
 
@@ -21,7 +27,7 @@ endif()
 
 pybind11_add_module(pypatchworkpp patchworkpp/pybinding.cpp)
 
-target_link_libraries(pypatchworkpp PUBLIC PATCHWORK::patchworkpp)
+target_link_libraries(pypatchworkpp PUBLIC ${PARENT_PROJECT_NAME}::${TARGET_NAME})
 
 if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
   target_compile_options(pypatchworkpp PUBLIC -fsized-deallocation)