Add input converter tests

Author: rasmusjp

src/Our.Umbraco.GraphQL/Web/InputConverter.cs renamed to src/Our.Umbraco.GraphQL/Json/Converters/InputsConverter.cs

@@ -1,31 +1,24 @@
-using GraphQL;
-using Newtonsoft.Json;
 using System;
 using System.Collections.Generic;
+using GraphQL;
+using Newtonsoft.Json;
 
-namespace Our.Umbraco.GraphQL.Web
+namespace Our.Umbraco.GraphQL.Json.Converters
 {
-    internal class InputConverter : JsonConverter
+    internal class InputsConverter : JsonConverter
     {
-        public override bool CanConvert(Type objectType)
-        {
-            return objectType == typeof(Inputs);
-        }
+        public override bool CanConvert(Type objectType) => objectType == typeof(Inputs);
+
+        public override bool CanWrite => false;
 
         public override object ReadJson(JsonReader reader, Type objectType, object existingValue,
             JsonSerializer serializer)
         {
-
-            if (reader.TokenType == JsonToken.Null)
-                return null;
-
             var dict = serializer.Deserialize<Dictionary<string, object>>(reader);
-
             return new Inputs(dict ?? new Dictionary<string, object>());
         }
-        public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer)
-        {
+
+        public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer) =>
             throw new NotSupportedException();
-        }
     }
 }

src/Our.Umbraco.GraphQL/Properties/AssemblyInfo.cs

@@ -0,0 +1,3 @@
+using System.Runtime.CompilerServices;
+
+[assembly: InternalsVisibleTo("Our.Umbraco.GraphQL.Tests")]

src/Our.Umbraco.GraphQL/Web/GraphQLQuery.cs

@@ -1,20 +1,6 @@
 using GraphQL;
-using GraphQL.Conversion;
-using GraphQL.Http;
-using GraphQL.Utilities;
-using LightInject;
-using Microsoft.Owin;
-using Microsoft.Owin.Cors;
 using Newtonsoft.Json;
-using Owin;
-using StackExchange.Profiling;
-using System;
-using System.Collections.Generic;
-using System.IO;
-using System.Linq;
-using System.Threading.Tasks;
-using System.Web.Cors;
-using Umbraco.Web;
+using Our.Umbraco.GraphQL.Json.Converters;
 
 namespace Our.Umbraco.GraphQL.Web
 {
@@ -24,7 +10,7 @@ public class GraphQLQuery
         public string OperationName { get; set; }
         public string Query { get; set; }
 
-        [JsonConverter(typeof(InputConverter))]
+        [JsonConverter(typeof(InputsConverter))]
         public Inputs Variables { get; set; }
     }
-}
+}

test/Our.Umbraco.GraphQL.Tests/Json/InputConverterTests.cs

@@ -0,0 +1,73 @@
+using System;
+using System.IO;
+using FluentAssertions;
+using GraphQL;
+using Newtonsoft.Json;
+using Our.Umbraco.GraphQL.Json.Converters;
+using Xunit;
+
+namespace Our.Umbraco.GraphQL.Tests.Json
+{
+    public class InputConverterTests
+    {
+        [Fact]
+        public void CanConvert_WithInputsType_ReturnsTrue()
+        {
+            var converter = new InputsConverter();
+
+            converter.CanConvert(typeof(Inputs))
+                .Should().BeTrue();
+        }
+
+        [Fact]
+        public void CanConvert_WithNonInputsType_ReturnsFalse()
+        {
+            var converter = new InputsConverter();
+
+            converter.CanConvert(typeof(string))
+                .Should().BeFalse();
+        }
+
+        [Fact]
+        public void CanWrite_ReturnsFalse()
+        {
+            var converter = new InputsConverter();
+
+            converter.CanWrite.Should().BeFalse();
+        }
+
+        [Fact]
+        public void WriteJson_ThrowsNotSupportedException()
+        {
+            var converter = new InputsConverter();
+
+            Action action = () => converter.WriteJson(null, null, null);
+            action.Should().Throw<NotSupportedException>();
+        }
+
+        [Fact]
+        public void ReadJson_WithData_ReturnsInputs()
+        {
+            var converter = new InputsConverter();
+
+            var data = converter.ReadJson(new JsonTextReader(new StringReader("{\"name\": \"test\"}")), typeof(Inputs),
+                null, new JsonSerializer());
+
+            data.Should().BeOfType<Inputs>()
+                .Which.Should().ContainKey("name")
+                .WhichValue.Should().Be("test");
+        }
+
+        [Fact]
+        public void ReadJson_WithNoData_ReturnsEmptyInputs()
+        {
+            var converter = new InputsConverter();
+
+            var data = converter.ReadJson(new JsonTextReader(new StringReader("null")), typeof(Inputs),
+                null, new JsonSerializer());
+
+            data.Should().BeOfType<Inputs>()
+                .Which.Should().BeEmpty();
+        }
+    }
+}