Skip to content

Commit fe917df

Browse files
Merge branch '6.4' into 7.0
* 6.4: fix typo Add types to private and internal properties [Workflow] Cleaning code [Scheduler] Fix NPE in debug:scheduler command
2 parents c53d8be + cfa88ba commit fe917df

File tree

4 files changed

+10
-11
lines changed

4 files changed

+10
-11
lines changed

Command/CompleteCommand.php

+2-3
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,8 @@ final class CompleteCommand extends Command
3434
{
3535
public const COMPLETION_API_VERSION = '1';
3636

37-
private $completionOutputs;
38-
39-
private $isDebug = false;
37+
private array $completionOutputs;
38+
private bool $isDebug = false;
4039

4140
/**
4241
* @param array<string, class-string<CompletionOutputInterface>> $completionOutputs A list of additional completion outputs, with shell name as key and FQCN as value

Completion/CompletionInput.php

+5-5
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,11 @@ final class CompletionInput extends ArgvInput
3131
public const TYPE_OPTION_NAME = 'option_name';
3232
public const TYPE_NONE = 'none';
3333

34-
private $tokens;
35-
private $currentIndex;
36-
private $completionType;
37-
private $completionName;
38-
private $completionValue = '';
34+
private array $tokens;
35+
private int $currentIndex;
36+
private string $completionType;
37+
private ?string $completionName = null;
38+
private string $completionValue = '';
3939

4040
/**
4141
* Converts a terminal string into tokens.

Completion/CompletionSuggestions.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@
2020
*/
2121
final class CompletionSuggestions
2222
{
23-
private $valueSuggestions = [];
24-
private $optionSuggestions = [];
23+
private array $valueSuggestions = [];
24+
private array $optionSuggestions = [];
2525

2626
/**
2727
* Add a suggested value for an input option or argument.

Tester/CommandCompletionTester.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
*/
2323
class CommandCompletionTester
2424
{
25-
private $command;
25+
private Command $command;
2626

2727
public function __construct(Command $command)
2828
{

0 commit comments

Comments
 (0)