Skip to content

Use base fixture from tar to prevent permission problems #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Vampire
Copy link
Contributor

@Vampire Vampire commented Apr 14, 2020

At least on Cygwin there were problems when the files in the base fixture were
created by a Git checkout, as Git does not care about permissions besides
executable flag.
But for the SVN repo properly functioning, permissions seem to be crucial.
So now the base fixture is extracted from a tar archive instead.

@Vampire
Copy link
Contributor Author

Vampire commented Apr 14, 2020

@tnyblom do you prefer the single PRs I posted now and I rebase after you merged (because conflicts in test files), or do you want me to combine all in one PR?

@tnyblom
Copy link
Contributor

tnyblom commented Apr 14, 2020

@Vampire What ever you like :)

@Vampire
Copy link
Contributor Author

Vampire commented Apr 15, 2020

Well, I'm currently done with changes, unless I find another bug during the conversion I'm currently doing. :-)

@Vampire
Copy link
Contributor Author

Vampire commented Apr 15, 2020

Argh, please wait with further merges, except for this one here which is safe.
I combined my PRs and used it and it greatly misbehaves.
I'll investigate later where I fucked up.

@Vampire
Copy link
Contributor Author

Vampire commented Apr 15, 2020

You can continue merging my PRs, the one that breaks it is #96 and I pushed a test that fails so you do not merge it accidentally.
Btw. in the settings of the GitHub repo you can require that the check be successful for merging.

@Vampire
Copy link
Contributor Author

Vampire commented Apr 15, 2020

Ok, #96 should be correct too now. :-)

@tnyblom tnyblom merged commit 34c2d55 into svn-all-fast-export:master Apr 15, 2020
@Vampire Vampire deleted the use-base-fixture-from-tar branch April 15, 2020 21:28
@katanacrimson
Copy link

katanacrimson commented Aug 25, 2020

FWIW, this PR causes all tests to fail when building a docker image using the dockerfile in the repository. It appears that the version of tar that ships with Debian 8.11 is too old to support --one-top-level.

@katanacrimson
Copy link

katanacrimson commented Aug 25, 2020

Actually, looking further, it looks like the tests were never utilized in conjunction with the dockerfile (which predates them) at all. Nevermind me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants