Rails: switch over to minimal Rails (#876)

I've been running this on my own instance for a couple of weeks and it
seems to be stable. I ran into some issues with CSRF tokens which I've
fixed, but aside from that it seems like it works!

Author: mockdeep

.rubocop_todo.yml

@@ -398,5 +398,6 @@ Style/StaticClass:
 # Offense count: 3
 Style/TopLevelMethodDefinition:
   Exclude:
+    - 'bin/setup'
     - 'spec/integration/feed_importing_spec.rb'
     - 'spec/support/active_record.rb'

Gemfile

@@ -19,12 +19,7 @@ gem "pg"
 gem "puma", "~> 6.0"
 gem "rack-ssl"
 gem "sass"
-gem "sinatra"
-gem "sinatra-activerecord"
-gem "sinatra-contrib"
-gem "sinatra-flash"
 gem "sprockets"
-gem "sprockets-helpers"
 gem "sprockets-rails"
 gem "thread"
 gem "uglifier"

Gemfile.lock

@@ -142,10 +142,7 @@ GEM
     mini_portile2 (2.8.1)
     minitest (5.17.0)
     msgpack (1.6.0)
-    multi_json (1.15.0)
     multi_xml (0.6.0)
-    mustermann (3.0.0)
-      ruby2_keywords (~> 0.0.1)
     net-imap (0.3.4)
       date
       net-protocol
@@ -174,8 +171,6 @@ GEM
       nio4r (~> 2.0)
     racc (1.6.2)
     rack (2.2.6.2)
-    rack-protection (3.0.5)
-      rack
     rack-ssl (1.4.1)
       rack
     rack-test (2.0.2)
@@ -263,7 +258,6 @@ GEM
       rubocop (~> 1.33)
       rubocop-capybara (~> 2.17)
     ruby-progressbar (1.11.0)
-    ruby2_keywords (0.0.5)
     rubyzip (2.3.2)
     sass (3.7.4)
       sass-listen (~> 4.0.0)
@@ -281,27 +275,9 @@ GEM
       simplecov_json_formatter (~> 0.1)
     simplecov-html (0.12.3)
     simplecov_json_formatter (0.1.4)
-    sinatra (3.0.5)
-      mustermann (~> 3.0)
-      rack (~> 2.2, >= 2.2.4)
-      rack-protection (= 3.0.5)
-      tilt (~> 2.0)
-    sinatra-activerecord (2.0.26)
-      activerecord (>= 4.1)
-      sinatra (>= 1.0)
-    sinatra-contrib (3.0.5)
-      multi_json
-      mustermann (~> 3.0)
-      rack-protection (= 3.0.5)
-      sinatra (= 3.0.5)
-      tilt (~> 2.0)
-    sinatra-flash (0.3.0)
-      sinatra (>= 1.0.0)
     sprockets (4.2.0)
       concurrent-ruby (~> 1.0)
       rack (>= 2.2.4, < 4)
-    sprockets-helpers (1.4.0)
-      sprockets (>= 2.2)
     sprockets-rails (3.4.2)
       actionpack (>= 5.2)
       activesupport (>= 5.2)
@@ -311,7 +287,6 @@ GEM
       tins (~> 1.0)
     thor (1.2.1)
     thread (0.2.2)
-    tilt (2.0.11)
     timecop (0.9.6)
     timeout (0.3.1)
     tins (1.32.1)
@@ -374,12 +349,7 @@ DEPENDENCIES
   sass
   selenium-webdriver
   simplecov
-  sinatra
-  sinatra-activerecord
-  sinatra-contrib
-  sinatra-flash
   sprockets
-  sprockets-helpers
   sprockets-rails
   thread
   timecop

Rakefile

@@ -1,33 +1,13 @@
 # frozen_string_literal: true
 
-require "bundler"
-Bundler.setup
+require_relative "config/application"
+
+Rails.application.load_tasks
 
-require "rubygems"
-require "net/http"
-require "active_record"
 require "active_support/core_ext/kernel/reporting"
 require "delayed_job"
 require "delayed_job_active_record"
 
-require "sinatra/activerecord/rake"
-ActiveRecord::Tasks::DatabaseTasks.db_dir = "db"
-
-require "./app"
-
-desc "Load app files"
-task :environment do
-  require_relative "./app/jobs/fetch_feed_job"
-  require_relative "./app/tasks/fetch_feeds"
-  require_relative "./app/tasks/change_password"
-  require_relative "./app/tasks/remove_old_stories"
-end
-
-desc "Open an irb session preloaded with the app"
-task :console do
-  sh "irb -r ./app.rb"
-end
-
 desc "Fetch all feeds."
 task fetch_feeds: :environment do
   FetchFeeds.new(Feed.all).fetch_all

app/assets/config/manifest.js

@@ -0,0 +1,3 @@
+//= link_tree ../images
+//= link_directory ../stylesheets .css
+//= link_directory ../javascripts .js

app/assets/javascripts/application.js

@@ -11,6 +11,16 @@ _.templateSettings = {
   evaluate: /\{\{(.+?)\}\}/g
 };
 
+function CSRFToken() {
+  const tokenTag = document.getElementsByName('csrf-token')[0];
+
+  return (tokenTag && tokenTag.content) || '';
+}
+
+function requestHeaders() {
+  return { 'X-CSRF-Token': CSRFToken() };
+}
+
 var Story = Backbone.Model.extend({
   defaults: function() {
     return {
@@ -33,7 +43,7 @@ var Story = Backbone.Model.extend({
 
   open: function() {
     if (!this.get("keep_unread")) this.set("is_read", true);
-    if (this.shouldSave()) this.save();
+    if (this.shouldSave()) this.save(null, { headers: requestHeaders() });
 
     if(this.collection){
       this.collection.closeOthers(this);
@@ -54,7 +64,7 @@ var Story = Backbone.Model.extend({
       this.set("is_read", false);
     }
 
-    if (this.shouldSave()) this.save();
+    if (this.shouldSave()) this.save(null, { headers: requestHeaders() });
   },
 
   toggleStarred: function() {
@@ -64,7 +74,7 @@ var Story = Backbone.Model.extend({
       this.set("is_starred", true);
     }
 
-    if (this.shouldSave()) this.save();
+    if (this.shouldSave()) this.save(null, { headers: requestHeaders() });
   },
 
   close: function() {
@@ -156,7 +166,7 @@ var StoryView = Backbone.View.extend({
       if (backgroundTab) backgroundTab.blur();
       window.focus();
       if (!this.model.get("keep_unread")) this.model.set("is_read", true);
-      if (this.model.shouldSave()) this.model.save();
+      if (this.model.shouldSave()) this.model.save(null, { headers: requestHeaders() });
     } else {
       this.model.toggle();
       window.scrollTo(0, this.$el.offset().top);

app/commands/fever_api/response.rb

@@ -1,21 +1,5 @@
 # frozen_string_literal: true
 
-require_relative "authentication"
-
-require_relative "read_groups"
-require_relative "read_feeds"
-require_relative "read_feeds_groups"
-require_relative "read_favicons"
-require_relative "read_items"
-require_relative "read_links"
-
-require_relative "sync_unread_item_ids"
-require_relative "sync_saved_item_ids"
-
-require_relative "write_mark_item"
-require_relative "write_mark_feed"
-require_relative "write_mark_group"
-
 module FeverAPI
   API_VERSION = 3
 

app/controllers/application_controller.rb

@@ -1,31 +1,15 @@
 # frozen_string_literal: true
 
 class ApplicationController < ActionController::Base
-  before_action :append_view_path
   before_action :complete_setup
   before_action :authenticate_user
-  after_action :rotate_flash
 
   private
 
-  # needed for Sinatra
-  def append_view_path
-    super("./app/views")
-  end
-
   def complete_setup
     redirect_to("/setup/password") unless UserRepository.setup_complete?
   end
 
-  def flash
-    @flash ||= Sinatra::Flash::FlashHash.new(session[:flash])
-  end
-  helper_method :flash
-
-  def rotate_flash
-    session[:flash] = flash.next # for Sinatra
-  end
-
   def authenticate_user
     return if current_user
 

app/controllers/fever_controller.rb

@@ -1,8 +1,11 @@
 # frozen_string_literal: true
 
+require_relative "../commands/fever_api/response"
+
 class FeverController < ApplicationController
   skip_before_action :complete_setup, only: [:index, :update]
   skip_before_action :authenticate_user, only: [:index, :update]
+  protect_from_forgery with: :null_session, only: [:update]
   before_action :authenticate_fever
 
   def index

app/views/layouts/application.html.erb

@@ -5,6 +5,7 @@
       <%= content_for(:title) %>
       <%= t('layout.title') %>
     </title>
+    <%= csrf_meta_tags %>
     <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
     <meta name="viewport" content="width=device-width, initial-scale=1" />
     <link rel="shortcut icon" href="/img/favicon.png">

bin/rails

@@ -0,0 +1,6 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+APP_PATH = File.expand_path("../config/application", __dir__)
+require_relative "../config/boot"
+require "rails/commands"

bin/rake

@@ -0,0 +1,6 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+require_relative "../config/boot"
+require "rake"
+Rake.application.run

bin/setup

@@ -0,0 +1,35 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+require "fileutils"
+
+# path to your application root.
+APP_ROOT = File.expand_path("..", __dir__)
+
+def system!(*args)
+  system(*args) || abort("\n== Command #{args} failed ==")
+end
+
+FileUtils.chdir(APP_ROOT) do
+  # This script is a way to set up or update your development environment
+  # automatically. This script is idempotent, so that you can run it at any
+  # time and get an expectable outcome. Add necessary setup steps to this file.
+
+  puts "== Installing dependencies =="
+  system! "gem install bundler --conservative"
+  system("bundle check") || system!("bundle install")
+
+  # puts "\n== Copying sample files =="
+  # unless File.exist?("config/database.yml")
+  #   FileUtils.cp "config/database.yml.sample", "config/database.yml"
+  # end
+
+  puts "\n== Preparing database =="
+  system! "bin/rails db:prepare"
+
+  puts "\n== Removing old logs and tempfiles =="
+  system! "bin/rails log:clear tmp:clear"
+
+  puts "\n== Restarting application server =="
+  system! "bin/rails restart"
+end

config.ru

@@ -1,10 +1,9 @@
 # frozen_string_literal: true
 
-require "rubygems"
-require "bundler"
+# This file is used by Rack-based servers to start the application.
 
 require "active_support/core_ext/kernel/reporting"
-Bundler.require
+require_relative "config/environment"
 
-require "./app"
-run Stringer
+run Rails.application
+Rails.application.load_server

config/application.rb

@@ -0,0 +1,43 @@
+# frozen_string_literal: true
+
+require_relative "boot"
+
+require "rails"
+# Pick the frameworks you want:
+require "active_model/railtie"
+# require "active_job/railtie"
+require "active_record/railtie"
+# require "active_storage/engine"
+require "action_controller/railtie"
+# require "action_mailer/railtie"
+# require "action_mailbox/engine"
+# require "action_text/engine"
+require "action_view/railtie"
+# require "action_cable/engine"
+require "rails/test_unit/railtie"
+
+# Require the gems listed in Gemfile, including any gems
+# you've limited to :test, :development, or :production.
+Bundler.require(*Rails.groups)
+
+module Stringer
+  class Application < Rails::Application
+    # Initialize configuration defaults for originally generated Rails version.
+    config.load_defaults(7.0)
+
+    # Configuration for the application, engines, and railties goes here.
+    #
+    # These settings can be overridden in specific environments using the files
+    # in config/environments, which are processed later.
+    #
+    # config.time_zone = "Central Time (US & Canada)"
+    config.eager_load_paths << Rails.root.join("app/commands/feeds")
+    config.eager_load_paths << Rails.root.join("app/commands/stories")
+    config.eager_load_paths << Rails.root.join("app/commands/users")
+
+    # Don't generate system test files.
+    config.generators.system_tests = nil
+
+    config.active_record.belongs_to_required_by_default = false
+  end
+end

config/boot.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../Gemfile", __dir__)
+
+require "bundler/setup" # Set up gems listed in the Gemfile.

config/environment.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+# Load the Rails application.
+require_relative "application"
+
+# Initialize the Rails application.
+Rails.application.initialize!