Rails: alias last_response to response (#863)

Author: mockdeep

spec/config/asset_pipeline_spec.rb

@@ -8,6 +8,6 @@
   it "handles asset requests" do
     get("/assets/stylesheets/application.css")
 
-    expect(last_response.body).to match("#feed-title")
+    expect(response.body).to match("#feed-title")
   end
 end

spec/requests/debug_controller_spec.rb

@@ -21,7 +21,7 @@ def setup
 
       get "/debug"
 
-      page = last_response.body
+      page = response.body
       expect(page).to have_tag("dd", text: /#{RUBY_VERSION}/)
     end
 
@@ -31,7 +31,7 @@ def setup
 
       get "/debug"
 
-      page = last_response.body
+      page = response.body
       expect(page).to have_tag("dd", text: /testy/)
     end
 
@@ -40,7 +40,7 @@ def setup
 
       get "/debug"
 
-      page = last_response.body
+      page = response.body
       expect(page).to have_tag("dd", text: /42/)
     end
 
@@ -49,7 +49,7 @@ def setup
 
       get "/debug"
 
-      rendered = Capybara.string(last_response.body)
+      rendered = Capybara.string(response.body)
       expect(rendered).to have_selector("li", text: /Migration B - 2/)
         .and have_selector("li", text: /Migration C - 3/)
     end
@@ -59,7 +59,7 @@ def setup
     it "displays Heroku instructions" do
       get("/heroku")
 
-      expect(last_response.body).to include("add an hourly task")
+      expect(response.body).to include("add an hourly task")
     end
   end
 end

spec/requests/exports_controller_spec.rb

@@ -21,15 +21,15 @@ def expected_xml
 
       get "/feeds/export"
 
-      expect(last_response.body).to eq(expected_xml)
+      expect(response.body).to eq(expected_xml)
     end
 
     it "responds with xml content type" do
       login_as(create(:user))
 
       get "/feeds/export"
 
-      expect(last_response.header["Content-Type"]).to include("application/xml")
+      expect(response.header["Content-Type"]).to include("application/xml")
     end
 
     it "responds with disposition attachment" do
@@ -39,7 +39,7 @@ def expected_xml
 
       expected =
         "attachment; filename=\"stringer.opml\"; filename*=UTF-8''stringer.opml"
-      expect(last_response.header["Content-Disposition"]).to eq(expected)
+      expect(response.header["Content-Disposition"]).to eq(expected)
     end
   end
 end

spec/requests/feeds_controller_spec.rb

@@ -10,7 +10,7 @@
 
       get "/feeds"
 
-      rendered = Capybara.string(last_response.body)
+      rendered = Capybara.string(response.body)
       expect(rendered).to have_selector("li.feed", count: 2)
     end
 
@@ -19,7 +19,7 @@
 
       get "/feeds"
 
-      page = last_response.body
+      page = response.body
       expect(page).to have_tag("#add-some-feeds")
     end
   end
@@ -31,7 +31,7 @@
 
       get "/feed/#{story.feed_id}"
 
-      expect(last_response.body).to have_tag("#stories")
+      expect(response.body).to have_tag("#stories")
     end
   end
 
@@ -42,7 +42,7 @@
 
       get "/feeds/#{feed.id}/edit"
 
-      rendered = Capybara.string(last_response.body)
+      rendered = Capybara.string(response.body)
       expect(rendered).to have_field("feed_name", with: "Rainbows/unicorns")
     end
   end
@@ -93,7 +93,7 @@ def params(feed, **overrides)
 
       get "/feeds/new"
 
-      page = last_response.body
+      page = response.body
       expect(page).to have_tag("form#add-feed-setup")
     end
   end
@@ -127,7 +127,7 @@ def params(feed, **overrides)
         stub_request(:get, feed_url).to_return(status: 404)
         post("/feeds", params: { feed_url: })
 
-        page = last_response.body
+        page = response.body
         expect(page).to have_tag(".error")
       end
     end
@@ -142,7 +142,7 @@ def params(feed, **overrides)
 
         post("/feeds", params: { feed_url: })
 
-        expect(last_response.body).to have_tag(".error")
+        expect(response.body).to have_tag(".error")
       end
     end
   end

spec/requests/fever_controller_spec.rb

@@ -11,8 +11,8 @@ def cannot_auth
     { api_version: 3, auth: 0 }
   end
 
-  def last_response_as_object
-    JSON.parse(last_response.body, symbolize_names: true)
+  def response_as_object
+    JSON.parse(response.body, symbolize_names: true)
   end
 
   def params(user: create(:user), **overrides)
@@ -23,29 +23,29 @@ def params(user: create(:user), **overrides)
     it "authenticates request with correct api_key" do
       get("/fever", params:)
 
-      expect(last_response_as_object).to include(standard_answer)
+      expect(response_as_object).to include(standard_answer)
     end
 
     it "does not authenticate request with incorrect api_key" do
       get "/fever", params: params(api_key: "foo")
 
-      expect(last_response_as_object).to include(cannot_auth)
+      expect(response_as_object).to include(cannot_auth)
     end
 
     it "does not authenticate request when api_key is not provided" do
       create(:user)
 
       get "/fever", params: params(api_key: nil)
 
-      expect(last_response_as_object).to include(cannot_auth)
+      expect(response_as_object).to include(cannot_auth)
     end
   end
 
   describe "#get" do
     it "returns standard answer" do
       get("/fever", params:)
 
-      expect(last_response_as_object).to include(standard_answer)
+      expect(response_as_object).to include(standard_answer)
     end
 
     it "returns groups and feeds by groups when 'groups' header is provided" do
@@ -54,7 +54,7 @@ def params(user: create(:user), **overrides)
       get("/fever", params: params(groups: nil))
 
       groups = [{ group_id: feed.group_id, feed_ids: feed.id.to_s }]
-      expect(last_response_as_object).to include(standard_answer)
+      expect(response_as_object).to include(standard_answer)
         .and include(groups: [feed.group.as_fever_json], feeds_groups: groups)
     end
 
@@ -64,15 +64,15 @@ def params(user: create(:user), **overrides)
       get("/fever", params: params(feeds: nil))
 
       groups = [{ group_id: feed.group_id, feed_ids: feed.id.to_s }]
-      expect(last_response_as_object).to include(standard_answer)
+      expect(response_as_object).to include(standard_answer)
         .and include(feeds: [feed.as_fever_json], feeds_groups: groups)
     end
 
     it "returns favicons hash when 'favicons' header provided" do
       get("/fever", params: params(favicons: nil))
 
       favicon = { id: 0, data: a_string_including("image/gif;base64") }
-      expect(last_response_as_object).to include(standard_answer)
+      expect(response_as_object).to include(standard_answer)
         .and include(favicons: [favicon])
     end
 
@@ -82,7 +82,7 @@ def params(user: create(:user), **overrides)
 
       get("/fever", params: params(items: nil, since_id: 5))
 
-      expect(last_response_as_object).to include(standard_answer)
+      expect(response_as_object).to include(standard_answer)
         .and include(items: [story_two.as_fever_json], total_items: 2)
     end
 
@@ -91,7 +91,7 @@ def params(user: create(:user), **overrides)
 
       get("/fever", params: params(items: nil))
 
-      expect(last_response_as_object).to include(standard_answer)
+      expect(response_as_object).to include(standard_answer)
         .and include(items: stories.map(&:as_fever_json), total_items: 2)
     end
 
@@ -100,14 +100,14 @@ def params(user: create(:user), **overrides)
 
       get("/fever", params: params(items: nil, with_ids: story.id))
 
-      expect(last_response_as_object).to include(standard_answer)
+      expect(response_as_object).to include(standard_answer)
         .and include(items: [story.as_fever_json], total_items: 1)
     end
 
     it "returns links as empty array when 'links' header is provided" do
       get("/fever", params: params(links: nil))
 
-      expect(last_response_as_object).to include(standard_answer)
+      expect(response_as_object).to include(standard_answer)
         .and include(links: [])
     end
 
@@ -116,7 +116,7 @@ def params(user: create(:user), **overrides)
 
       get("/fever", params: params(unread_item_ids: nil))
 
-      expect(last_response_as_object).to include(standard_answer)
+      expect(response_as_object).to include(standard_answer)
         .and include(unread_item_ids: stories.map(&:id).join(","))
     end
 
@@ -125,7 +125,7 @@ def params(user: create(:user), **overrides)
 
       get("/fever", params: params(saved_item_ids: nil))
 
-      expect(last_response_as_object).to include(standard_answer)
+      expect(response_as_object).to include(standard_answer)
         .and include(saved_item_ids: stories.map(&:id).join(","))
     end
   end
@@ -136,31 +136,31 @@ def params(user: create(:user), **overrides)
 
       post("/fever", params: params(mark: "item", as: "read", id: story.id))
 
-      expect(last_response_as_object).to include(standard_answer)
+      expect(response_as_object).to include(standard_answer)
     end
 
     it "commands to mark story as unread" do
       story = create(:story, :read)
 
       post("/fever", params: params(mark: "item", as: "unread", id: story.id))
 
-      expect(last_response_as_object).to include(standard_answer)
+      expect(response_as_object).to include(standard_answer)
     end
 
     it "commands to save story" do
       story = create(:story)
 
       post("/fever", params: params(mark: "item", as: "saved", id: story.id))
 
-      expect(last_response_as_object).to include(standard_answer)
+      expect(response_as_object).to include(standard_answer)
     end
 
     it "commands to unsave story" do
       story = create(:story, :starred)
 
       post("/fever", params: params(mark: "item", as: "unsaved", id: story.id))
 
-      expect(last_response_as_object).to include(standard_answer)
+      expect(response_as_object).to include(standard_answer)
     end
 
     it "commands to mark group as read" do
@@ -170,7 +170,7 @@ def params(user: create(:user), **overrides)
 
       post("/fever", params: params(mark: "group", as: "read", id:, before:))
 
-      expect(last_response_as_object).to include(standard_answer)
+      expect(response_as_object).to include(standard_answer)
     end
 
     it "commands to mark entire feed as read" do

spec/requests/imports_controller_spec.rb

@@ -9,7 +9,7 @@
 
       get "/feeds/import"
 
-      page = last_response.body
+      page = response.body
       expect(page).to have_tag("input#opml_file")
     end
   end

spec/requests/passwords_controller_spec.rb

@@ -13,7 +13,7 @@ def setup
 
       get "/setup/password"
 
-      page = last_response.body
+      page = response.body
       expect(page).to have_tag("form#password_setup")
     end
   end
@@ -24,7 +24,7 @@ def setup
 
       post "/setup/password"
 
-      page = last_response.body
+      page = response.body
       expect(page).to have_tag("div.error")
     end
 
@@ -34,15 +34,15 @@ def setup
       post "/setup/password",
            params: { password: "foo", password_confirmation: "bar" }
 
-      page = last_response.body
+      page = response.body
       expect(page).to have_tag("div.error")
     end
 
     it "accepts confirmed passwords and redirects to next step" do
       post "/setup/password",
            params: { password: "foo", password_confirmation: "foo" }
 
-      expect(URI.parse(last_response.location).path).to eq("/feeds/import")
+      expect(URI.parse(response.location).path).to eq("/feeds/import")
     end
   end
 end