Replace sinatra-assetpack with sprockets

In this change, I'm replacing Sinatra-assetpack with sprockets because
assetpack is no longer maintained. Sprockets is in active development and has a
very good non-Rails support.

I also noticed that we are not compiling assets on Heroku. For Rails
applications, the buildpack will run `rake assets:precompile`, but there isn't
anything similar for rack based applications. The best option would be fork the
buildpack, but because each instance of String only serves one user, I don't
think it will become a problem.

This change solves issue #427

Author: gabrielpoca

.ruby-version

@@ -1 +1 @@
-2.3.0
+2.3.3

.travis.yml

@@ -8,7 +8,7 @@ before_script:
 cache: bundler
 language: ruby
 rvm:
-  - 2.3.0
+  - 2.3.3
   - ruby-head
 matrix:
   allow_failures:

Gemfile

@@ -33,14 +33,17 @@ gem "feedjira", "~> 2.1.0"
 gem "i18n"
 gem "loofah", "~> 2.0"
 gem "nokogiri", "~> 1.6", ">= 1.6.7.2"
+gem "rack-protection", "~> 1.5"
 gem "rack-ssl", "~> 1.4"
 gem "racksh", "~> 1.0"
 gem "rake", "~> 10.1", ">= 10.1.1"
+gem "sass"
 gem "sinatra", "~> 1.4.8", ">= 1.4.8"
 gem "sinatra-activerecord", "~> 1.2", ">= 1.2.3"
-gem "sinatra-assetpack", "~> 0.3", require: "sinatra/assetpack"
 gem "sinatra-contrib", "~> 1.4.7"
 gem "sinatra-flash", "~> 0.3"
+gem "sprockets", "~> 3.0"
+gem "sprockets-helpers"
 gem "thread", "~> 0.2"
+gem "uglifier"
 gem "will_paginate", "~> 3.1"
-gem "rack-protection", "~> 1.5"

Gemfile.lock

@@ -32,6 +32,7 @@ GEM
       xpath (~> 2.0)
     coderay (1.1.1)
     columnize (0.9.0)
+    concurrent-ruby (1.0.2)
     coveralls (0.8.13)
       json (~> 1.8)
       simplecov (~> 0.11.0)
@@ -46,6 +47,7 @@ GEM
       delayed_job (>= 3.0, < 5)
     diff-lcs (1.2.5)
     docile (1.1.5)
+    execjs (2.7.0)
     faker (1.6.3)
       i18n (~> 0.5)
     faraday (0.11.0)
@@ -60,7 +62,6 @@ GEM
       loofah (>= 2.0)
       sax-machine (>= 1.0)
     i18n (0.7.0)
-    jsmin (1.0.1)
     json (1.8.3)
     kgio (2.10.0)
     loofah (2.0.3)
@@ -122,6 +123,7 @@ GEM
       ruby-progressbar (~> 1.7)
       unicode-display_width (~> 1.0, >= 1.0.1)
     ruby-progressbar (1.7.5)
+    sass (3.4.22)
     sax-machine (1.3.2)
     shotgun (0.9.1)
       rack (>= 1.0)
@@ -137,11 +139,6 @@ GEM
     sinatra-activerecord (1.7.0)
       activerecord (>= 3.0)
       sinatra (~> 1.0)
-    sinatra-assetpack (0.3.5)
-      jsmin
-      rack-test
-      sinatra
-      tilt (>= 1.3.0, < 2.0)
     sinatra-contrib (1.4.7)
       backports (>= 2.0)
       multi_json
@@ -152,6 +149,11 @@ GEM
     sinatra-flash (0.3.0)
       sinatra (>= 1.0.0)
     slop (3.6.0)
+    sprockets (3.7.0)
+      concurrent-ruby (~> 1.0)
+      rack (> 1, < 3)
+    sprockets-helpers (1.2.1)
+      sprockets (>= 2.2)
     sqlite3 (1.3.11)
     term-ansicolor (1.3.2)
       tins (~> 1.0)
@@ -163,6 +165,8 @@ GEM
     tins (1.6.0)
     tzinfo (1.2.2)
       thread_safe (~> 0.1)
+    uglifier (3.0.2)
+      execjs (>= 0.3.0, < 3)
     unicode-display_width (1.0.2)
     unicorn (4.9.0)
       kgio (~> 2.6)
@@ -198,20 +202,23 @@ DEPENDENCIES
   rspec (~> 3.4)
   rspec-html-matchers (~> 0.7)
   rubocop (~> 0.38)
+  sass
   shotgun (~> 0.9)
   sinatra (~> 1.4.8, >= 1.4.8)
   sinatra-activerecord (~> 1.2, >= 1.2.3)
-  sinatra-assetpack (~> 0.3)
   sinatra-contrib (~> 1.4.7)
   sinatra-flash (~> 0.3)
+  sprockets (~> 3.0)
+  sprockets-helpers
   sqlite3 (~> 1.3, >= 1.3.8)
   thread (~> 0.2)
   timecop (~> 0.8)
+  uglifier
   unicorn (~> 4.7)
   will_paginate (~> 3.1)
 
 RUBY VERSION
-   ruby 2.3.0p0
+   ruby 2.3.3p222
 
 BUNDLED WITH
-   1.14.5
+   1.14.6

app.rb

@@ -2,15 +2,17 @@
 require "sinatra/activerecord"
 require "sinatra/flash"
 require "sinatra/contrib/all"
-require "sinatra/assetpack"
 require "rack/ssl"
 require "json"
 require "i18n"
 require "will_paginate"
 require "will_paginate/active_record"
+require "sprockets"
+require "sprockets-helpers"
 
 require_relative "app/helpers/authentication_helpers"
 require_relative "app/repositories/user_repository"
+require_relative "config/asset_pipeline"
 
 I18n.load_path += Dir[File.join(File.dirname(__FILE__), "config/locales", "*.yml").to_s]
 I18n.config.enforce_available_locales = false
@@ -22,7 +24,7 @@ class Stringer < Sinatra::Base
   register Sinatra::ActiveRecordExtension
   register Sinatra::Flash
   register Sinatra::Contrib
-  register Sinatra::AssetPack
+  register AssetPipeline
 
   configure do
     set :database_file, "config/database.yml"
@@ -58,35 +60,6 @@ def t(*args)
     end
   end
 
-  assets do
-    serve "/js",     from: "app/public/js"
-    serve "/css",    from: "app/public/css"
-    serve "/images", from: "app/public/img"
-
-    js :application, "/js/application.js", [
-      "/js/jquery-min.js",
-      "/js/bootstrap-min.js",
-      "/js/bootstrap.file-input.js",
-      "/js/mousetrap-min.js",
-      "/js/jquery-visible-min.js",
-      "/js/underscore-min.js",
-      "/js/backbone-min.js",
-      "/js/app.js"
-    ]
-
-    css :application, "/css/application.css", [
-      "/css/bootstrap-min.css",
-      "/css/flat-ui-no-icons.css",
-      "/css/font-awesome-min.css",
-      "/css/styles.css"
-    ]
-
-    js_compression :jsmin
-    css_compression :simple
-
-    prebuild true unless ENV["RACK_ENV"] == "test"
-  end
-
   before do
     I18n.locale = ENV["LOCALE"].blank? ? :en : ENV["LOCALE"].to_sym
 

app/public/js/app.js renamed to app/assets/javascripts/application.js

@@ -1,3 +1,11 @@
+//= require jquery-min.js
+//= require bootstrap-min.js
+//= require bootstrap.file-input.js
+//= require mousetrap-min.js
+//= require jquery-visible-min.js
+//= require underscore-min.js
+//= require backbone-min.js
+
 _.templateSettings = {
   interpolate: /\{\{\=(.+?)\}\}/g,
   evaluate: /\{\{(.+?)\}\}/g

app/public/js/backbone-min.js renamed to app/assets/javascripts/backbone-min.js

@@ -1,3 +1,7 @@
+/*
+  *= require_tree .
+*/
+
 html, body {
   height: 100%;
   color: #484948;

app/public/js/bootstrap-min.js renamed to app/assets/javascripts/bootstrap-min.js

@@ -9,12 +9,11 @@
     <meta name="viewport" content="width=device-width, initial-scale=1" />
     <link rel="shortcut icon" href="/img/favicon.png">
     <link rel="apple-touch-icon-precomposed" href="/img/apple-touch-icon-precomposed.png">
-    <link href="/css/lato-fonts.css" rel="stylesheet" type="text/css">
 
     <%= yield_content :head %>
 
-    <%= css :application %>
-    <%= js  :application %>
+    <link href="<%= stylesheet_path 'application' %>" rel="stylesheet" />
+    <script src="<%= javascript_path 'application' %>"></script>
   </head>
   <body>
     <div id="wrap">

app/public/js/bootstrap.file-input.js renamed to app/assets/javascripts/bootstrap.file-input.js

@@ -0,0 +1,53 @@
+module AssetPipeline
+  def registered(app)
+    app.set :sprockets, Sprockets::Environment.new(app.root)
+
+    app.get "/assets/*" do
+      env["PATH_INFO"].sub!(%r{^/assets}, "")
+      settings.sprockets.call(env)
+    end
+
+    append_paths(app)
+    configure_development(app)
+    configure_production(app)
+    register_helpers(app)
+  end
+
+  private
+
+  def append_paths(app)
+    app.sprockets.append_path File.join(app.root, "app", "assets")
+    app.sprockets.append_path File.join(app.root, "app", "assets", "stylesheets")
+    app.sprockets.append_path File.join(app.root, "app", "assets", "javascripts")
+  end
+
+  def configure_development(app)
+    app.configure :development do
+      app.sprockets.cache = Sprockets::Cache::FileStore.new("./tmp")
+    end
+  end
+
+  def configure_production(app)
+    app.configure :production do
+      app.sprockets.css_compressor = :scss
+      app.sprockets.js_compressor = :uglify
+    end
+  end
+
+  def register_helpers(app)
+    Sprockets::Helpers.configure do |config|
+      config.environment = app.sprockets
+      config.prefix = "/assets"
+      config.debug = true if app.development?
+      config.digest = true if app.production?
+    end
+
+    app.helpers Sprockets::Helpers
+  end
+
+  module_function :registered,
+                  :append_paths,
+                  :configure_development,
+                  :configure_production,
+                  :register_helpers
+end

app/public/js/jquery-min.js renamed to app/assets/javascripts/jquery-min.js

@@ -61,8 +61,8 @@ We are going to use Rbenv to manage the version of Ruby you use.
     git clone git://github.com/sstephenson/ruby-build.git $HOME/.rbenv/plugins/ruby-build
     source ~/.bash_profile
 
-    rbenv install 2.3.0
-    rbenv local 2.3.0
+    rbenv install 2.3.3
+    rbenv local 2.3.3
     rbenv rehash
 
 We also need to install bundler which will handle Stringer's dependencies

app/public/js/jquery-visible-min.js renamed to app/assets/javascripts/jquery-visible-min.js

@@ -3,13 +3,13 @@
   <head>
     <title>Stringer JavaScript Test Suite</title>
     <meta http-equiv="Content-Type" content="text/html; charset=utf-8" >
-    <%= js :application %>
+    <script src="<%= javascript_path 'application' %>"></script>
 
     <% js_files.each do |js_file| %>
       <script src="<%= js_file %>"></script>
     <% end %>
     <% css_files.each do |css_file| %>
-      <link rel="stylesheet" type="text/css" href="<%= css_file%>">
+      <link rel="stylesheet" type="text/css" href="<%= css_file %>">
     <% end %>
 
     <!-- Javascript templates -->