Rails: add support for setting session in specs (#823)

Author: mockdeep

spec/app_spec.rb

@@ -40,17 +40,17 @@
   end
 
   it "does not redirect when user is authenticated" do
-    user = create(:user)
+    login_as(create(:user))
 
-    get("/news", {}, "rack.session" => { user_id: user.id })
+    get("/news")
 
     expect(last_response).not_to be_redirect
   end
 
   it "redirects '/' to '/news'" do
-    user = create(:user)
+    login_as(create(:user))
 
-    get("/", {}, "rack.session" => { user_id: user.id })
+    get("/")
 
     expect(last_response).to be_redirect
     expect(last_response.headers["Location"]).to end_with("/news")

spec/controllers/sessions_controller_spec.rb

@@ -41,21 +41,24 @@
       user = create(:user)
 
       params = { password: user.password }
-      post "/login", params, "rack.session" => { redirect_to: "/archive" }
+      session[:redirect_to] = "/archive"
+      post "/login", params
 
       expect(URI.parse(last_response.location).path).to eq("/archive")
     end
   end
 
   describe "#destroy" do
     it "clears the session" do
-      get "/logout", {}, "rack.session" => { userid: 1 }
+      session[:user_id] = 1
+      get "/logout"
 
       expect(session[:user_id]).to be_nil
     end
 
     it "redirects to the root page" do
-      get "/logout", {}, "rack.session" => { userid: 1 }
+      session[:user_id] = 1
+      get "/logout"
 
       expect(URI.parse(last_response.location).path).to eq("/")
     end

spec/controllers/tutorials_controller_spec.rb

@@ -10,9 +10,9 @@
       let(:feeds) { [instance_double(Feed), instance_double(Feed)] }
 
       it "displays the tutorial and completes setup" do
-        user = create(:user)
+        login_as(create(:user))
 
-        get "/setup/tutorial", {}, { "rack.session" => { user_id: user.id } }
+        get "/setup/tutorial"
 
         page = last_response.body
         expect(page).to have_tag("#mark-all-instruction")

spec/support/controller_helpers.rb

@@ -7,7 +7,35 @@ def app
     Stringer
   end
 
+  alias old_get get
+  def get(path, params = {}, env = {})
+    old_get(path, params, env.merge("rack.session" => session))
+    @session = last_request.env["rack.session"]
+  end
+
+  alias old_post post
+  def post(path, params = {}, env = {})
+    old_post(path, params, env.merge("rack.session" => session))
+    @session = last_request.env["rack.session"]
+  end
+
+  alias old_put put
+  def put(path, params = {}, env = {})
+    old_put(path, params, env.merge("rack.session" => session))
+    @session = last_request.env["rack.session"]
+  end
+
+  alias old_delete delete
+  def delete(path, params = {}, env = {})
+    old_delete(path, params, env.merge("rack.session" => session))
+    @session = last_request.env["rack.session"]
+  end
+
+  def login_as(user)
+    session[:user_id] = user.id
+  end
+
   def session
-    last_request.env["rack.session"]
+    @session ||= {}
   end
 end