Skip to content

Debug HCI frames only with PRINT_HCI_INFO defined #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

FRASTM
Copy link

@FRASTM FRASTM commented Jan 28, 2021

This avoids dumping HCI packets on the console as soon as the serial link is enabled.
In some situations, when the serial trace is on, all the HCI traces are not useful.
The PRINT_HCI_INFO is defined to dump packets only when needed.

Signed-off-by: Francois Ramu francois.ramu@st.com

This avoids dumping HCI packets on the console
as soon as the serial link is enabled.
In some situations, when the serial trace is on
all the HCI traces are not useful.

Signed-off-by: Francois Ramu <francois.ramu@st.com>
@FRASTM FRASTM requested review from cparata and fpistm January 28, 2021 17:17
@fpistm
Copy link
Member

fpistm commented Jan 28, 2021

Hi @FRASTM
I'm not really agreed with this PR as you modify the default HCI class so it diverge from original one.
From my point of view the _debug should be set only when trace are required at run time not compile time. Or maybe I missed something?

@FRASTM FRASTM closed this Feb 1, 2021
@FRASTM
Copy link
Author

FRASTM commented Feb 1, 2021

not useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants