Skip to content

Commit 1b95dc5

Browse files
committed
fix some comments and small changes
1 parent f709b33 commit 1b95dc5

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

decode.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ func Unmarshal(buf []byte, v interface{}) error {
2626
return Decode(NewValueReader(bytes.NewBuffer(buf), 0), v)
2727
}
2828

29-
// Decode reads bytes from r unmarshal to v, if you want use same Reader to Decode multi
29+
// Decode reads bytes from r unmarshal to v, if you want to use same Reader to Decode multi
3030
// values, you should use encoding.ValueReader as io.Reader.
3131
func Decode(r io.Reader, v interface{}) error {
3232
if v == nil {

types.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,7 @@ func structFields(typ reflect.Type) (fieldNum int, fields []fieldName) {
346346
}
347347
for i := 0; i < typ.NumField(); i++ {
348348
// exported field
349-
if f := typ.Field(i); f.PkgPath == "" {
349+
if f := typ.Field(i); f.IsExported() {
350350
tagStr := f.Tag.Get("rtl")
351351
ignored := false
352352
for _, tag := range strings.Split(tagStr, ",") {

valuereader.go

+5-5
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ func (r *bufValueReader) left() int {
155155
}
156156

157157
// next read more bytes to buffer when buffer is empty,
158-
// and return whether has more bytes in buffer
158+
// and return if it has more bytes in buffer
159159
func (r *bufValueReader) next() bool {
160160
if r.available > r.offset {
161161
return true
@@ -361,10 +361,10 @@ func ReadMultiLengthBytesFromReader(vr ValueReader, length int, bytes []byte) ([
361361
}
362362

363363
func NewValueReader(r io.Reader, bufferSize int) ValueReader {
364-
len := int(MaxSliceSize)
364+
l := MaxSliceSize
365365
lenner, ok := r.(Lenner)
366366
if ok {
367-
len = lenner.Len()
367+
l = lenner.Len()
368368
}
369369
if bufferSize > 0 {
370370
return &bufValueReader{
@@ -373,14 +373,14 @@ func NewValueReader(r io.Reader, bufferSize int) ValueReader {
373373
buffer: make([]byte, bufferSize),
374374
available: 0,
375375
offset: 0,
376-
readerSize: len,
376+
readerSize: l,
377377
}
378378
} else {
379379
return &noBufValueReader{
380380
reader: r,
381381
eof: false,
382382
readCount: 0,
383-
readerSize: len,
383+
readerSize: l,
384384
}
385385
}
386386
}

0 commit comments

Comments
 (0)