fix: page doesn't get refreshed when FAST_REFRESH=false (facebook#9884)

n3tr · ianschmitz · web-flow · commit 7e48117abfa2 · 2020-10-26T11:53:44.000-07:00
Co-authored-by: Ian Schmitz &lt;ianschmitz@gmail.com&gt;
diff --git a/packages/react-dev-utils/webpackHotDevClient.js b/packages/react-dev-utils/webpackHotDevClient.js
@@ -243,7 +243,8 @@ function tryApplyUpdates(onHotUpdateSuccess) {
   }
 
   function handleApplyUpdates(err, updatedModules) {
-    const hasReactRefresh = process.env.FAST_REFRESH !== 'false';
+    // NOTE: This var is injected by Webpack's DefinePlugin, and is a boolean instead of string.
+    const hasReactRefresh = process.env.FAST_REFRESH;
     const wantsForcedReload = err || !updatedModules || hadRuntimeError;
     // React refresh can handle hot-reloading over errors.
     if (!hasReactRefresh && wantsForcedReload) {

Original file line number	Diff line number	Diff line change
`@@ -243,7 +243,8 @@ function tryApplyUpdates(onHotUpdateSuccess) {`
`243`	`243`	`}`
`244`	`244`
`245`	`245`	`function handleApplyUpdates(err, updatedModules) {`
`246`		`- const hasReactRefresh = process.env.FAST_REFRESH !== 'false';`
	`246`	`+ // NOTE: This var is injected by Webpack's DefinePlugin, and is a boolean instead of string.`
	`247`	`+ const hasReactRefresh = process.env.FAST_REFRESH;`
`247`	`248`	`const wantsForcedReload = err \|\| !updatedModules \|\| hadRuntimeError;`
`248`	`249`	`// React refresh can handle hot-reloading over errors.`
`249`	`250`	`if (!hasReactRefresh && wantsForcedReload) {`