refacot test using selector

Author: akirasosa

src/app/components/header/header.component.spec.ts

@@ -143,7 +143,7 @@ describe('HeaderComponent', () => {
     }));
   }); // when signed in
 
-  fdescribe('when not signed in', () => {
+  describe('when not signed in', () => {
     beforeEach(initComponent());
 
     it('can be shown', () => {

src/app/components/related-user-list/related-user-list.component.html

@@ -6,6 +6,6 @@
   </li>
 </ul>
 
-<button class="btn btn-secondary moreBtn" type="button" (click)="loadMore()"
+<button class="btn btn-secondary" type="button" (click)="loadMore()"
         [disabled]="noMoreUsers">More
 </button>

src/app/components/related-user-list/related-user-list.component.spec.ts

@@ -75,14 +75,14 @@ describe('RelatedUserListComponent', () => {
     expect(gravatarDebugElement.componentInstance.alt).toEqual('test1');
     expect(gravatarDebugElement.componentInstance.hash).toEqual('9a3f499f653f7e8d4c5bf3ae0cf6418f');
 
-    const userLink: HTMLElement = cmpDebugElement.query(By.css('li>a')).nativeElement;
+    const userLink: HTMLElement = cmpDebugElement.query(By.css('a[href="/users/1"]')).nativeElement;
+    expect(userLink).toBeTruthy();
     expect(userLink.innerText).toEqual('test1');
-    expect(userLink.getAttribute('href')).toEqual('/users/1');
   });
 
   it('can load more', () => {
     const cmp: RelatedUserListComponent = cmpDebugElement.componentInstance;
-    const moreBtn = getDOM().querySelector(cmpDebugElement.nativeElement, '.moreBtn');
+    const moreBtn = getDOM().querySelector(cmpDebugElement.nativeElement, 'button');
     spyOn(cmp, 'listProvider').and.callThrough();
     moreBtn.click();
     expect(cmp.users.length).toEqual(4);

src/app/pages/+user-list/user-list.component.spec.ts

@@ -98,8 +98,8 @@ describe('UserListComponent', () => {
     expect(gravatarDebugElement.componentInstance.hash).toEqual('9a3f499f653f7e8d4c5bf3ae0cf6418f');
     expect(gravatarDebugElement.componentInstance.alt).toEqual('test1');
 
-    const userShowLink = cmpDebugElement.query(By.css('li>a')).nativeElement;
-    expect(userShowLink.getAttribute('href')).toEqual('/users/1');
+    const userShowLink = getDOM().querySelector(el, 'li > a[href="/users/1"]');
+    expect(userShowLink).toBeTruthy();
 
     const pager: PagerComponent = pagerDebugElement.componentInstance;
     expect(pager.totalPages).toEqual(1);

src/app/pages/auth/auth.component.spec.ts

@@ -89,8 +89,8 @@ describe('AuthComponent', () => {
 
   it('can navigate to signup page', () => {
     const el = cmpDebugElement.nativeElement;
-    const signupLink = getDOM().querySelector(el, 'a');
-    expect(signupLink.getAttribute('href')).toEqual('/signup');
+    const signupLink = getDOM().querySelector(el, 'a[href="/signup"]');
+    expect(signupLink).toBeTruthy();
   });
 
 });

src/app/pages/top/top.component.spec.ts

@@ -36,8 +36,8 @@ describe('TopComponent', () => {
 
   it('can be shown', () => {
     expect(cmpDebugElement).toBeTruthy();
-    const signupLink = cmpDebugElement.query(By.css('a')).nativeElement;
-    expect(signupLink.getAttribute('href')).toEqual('/signup');
+    const signupLink = cmpDebugElement.query(By.css('a[href="/signup"]')).nativeElement;
+    expect(signupLink).toBeTruthy();
   });
 
 });