Add support for Docker's credential stores and helpers #45269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
nosan
changed the title
nosan
force-pushed
the
44633
branch
3 times, most recently
from
7e7684d to
0990c9a
Compare
This commit includes Docker CLI default authentication, leveraging credential helpers, the credential store, and static credentials. Previously, empty credentials were used by default. With this commit, a DefaultDockerRegistryAuthentication is introduced. It reads the Docker configuration file and, based on its contents, determines the appropriate authentication details for the requested ImageReference Signed-off-by: Dmytro Nosan <dimanosan@gmail.com>
|
@philwebb |
|
Thanks, I've started and I'm hoping to finish something before RC1 but it's going to be tight :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I left TODO in
DefaultDockerRegistryAuthenticationfor consideration.I didn't have time to update the documentation.See #44633