Skip to content

Use new pressed property #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
felixfbecker opened this issue Mar 30, 2019 · 0 comments
Open

Use new pressed property #14

felixfbecker opened this issue Mar 30, 2019 · 0 comments

Comments

@felixfbecker
Copy link
Contributor

The discussions button in the toolbar is a toggle, so it should use the pressed property so it is styled properly when activated/deactivated.

Example:

https://github.com/sourcegraph/sourcegraph-typescript/blob/2a8d094a2cb01263df69b216d288685c15a1d378/package.json#L39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@felixfbecker