You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I will be opening a PR momentarily with a suggested fix.
Describe the bug
If you have nested arrays of objects and they both the top level and nested level move positions, you will not get the correct diff and delta objects.
This fixes issue seperman#540. Before this change the reference params were being swapped right after there was a move. This is because the move needed to have the original paths, but child changes needed the new paths. The problem was that nested moves swapped the reference parameters again after the move was recorded. This made the paths inaccurate since the parent did not have the params swapped but the child did.
Instead, we are no longer swapping when building the tree, but rather when we request the paths. The paths will not be swapped for the iterable_item_moved but it will be swapped for all other changes if there was a parent with an iterable_item_moved.
I will be opening a PR momentarily with a suggested fix.
Describe the bug
If you have nested arrays of objects and they both the top level and nested level move positions, you will not get the correct diff and delta objects.
To Reproduce
Example:
Expected behavior
Actual behavior:
The nested item path in
iterable_item_moved
is incorrect.OS, DeepDiff version and Python version (please complete the following information):
Additional context
I already have a fix with PR incoming.
The text was updated successfully, but these errors were encountered: