Skip to content

orderly-set 5.4.0 breaks deepdiff on Python 3.8 #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mallman-experian opened this issue Apr 11, 2025 · 2 comments
Open

orderly-set 5.4.0 breaks deepdiff on Python 3.8 #539

mallman-experian opened this issue Apr 11, 2025 · 2 comments

Comments

@mallman-experian
Copy link

Describe the bug

When we run our unit tests using deepdiff 8.4.2, it brings in orderly-set 5.4.0 and we see failure stack traces like

.venv/lib/python3.8/site-packages/deepdiff/__init__.py:10: in <module>
    from .diff import DeepDiff as DeepDiff
.venv/lib/python3.8/site-packages/deepdiff/diff.py:21: in <module>
    from deepdiff.helper import (strings, bytes_type, numbers, uuids, ListItemRemovedOrAdded, notpresent,
.venv/lib/python3.8/site-packages/deepdiff/helper.py:16: in <module>
    from orderly_set import StableSetEq as SetOrderedBase  # median: 1.0867 s for cache test, 5.63s for all tests
.venv/lib/python3.8/site-packages/orderly_set/__init__.py:1: in <module>
    from orderly_set.sets import OrderedSet, StableSet, StableSetEq, OrderlySet, SortedSet  # NOQA
.venv/lib/python3.8/site-packages/orderly_set/sets.py:50: in <module>
    class StableSet(MutableSet[T], Sequence[T]):
.venv/lib/python3.8/site-packages/orderly_set/sets.py:380: in StableSet
    def indexes(self, keys: list[Hashable]) -> list[int]:
E   TypeError: 'type' object is not subscriptable

This problem did not occur with the previous version of orderly-set, 5.3.2.

To Reproduce
Install and import deepdiff 8.4.2 using a fresh env (to get orderly-set 5.4.0).

Expected behavior

It doesn't break.

OS, DeepDiff version and Python version (please complete the following information):

  • OS: Ubuntu
  • Version ???
  • Python Version 3.8.18
  • DeepDiff Version 8.4.2
@noobie-bob
Copy link

FYI folks - seperman/orderly-set#11

@mallman-experian mallman-experian changed the title orderly-set 5.4.0 appears to break deepdiff orderly-set 5.4.0 breaks deepdiff on Python 3.8 Apr 16, 2025
@yossisolomon
Copy link

Same here, verified we have the same issue and pinning orderly-set to 5.3.2 fixes this on Python3.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants