Skip to content

Added CENX company as a user #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 17, 2018
Merged

Added CENX company as a user #51

merged 3 commits into from
Jan 17, 2018

Conversation

bkhouri
Copy link
Contributor

@bkhouri bkhouri commented Nov 23, 2017

Got approval to add my company, CENX, listed under the robot framework users.

fixes #50

@bkhouri bkhouri mentioned this pull request Nov 23, 2017
@bkhouri
Copy link
Contributor Author

bkhouri commented Nov 23, 2017

Please don't merge until I confirm the image with my company.

@bkhouri
Copy link
Contributor Author

bkhouri commented Jan 5, 2018

@Tattoo @pekkaklarck
Can we get this PR merged?

@Tattoo
Copy link
Member

Tattoo commented Jan 6, 2018

Hi @bkhouri ,

Few comments/questions:

Why is the logo for different thing than the description? The company is CENX, but the logo is "cortx"?

The logo does not follow the sizes of other logos ie. max height 68px, making it stand out on the page.

I'm afraid the description is also too wordy for the layout. Frankly, this bit:

with sophisticated real-time and historical analytics, comprehensive visualization, real-time operations, and closed-loop automation capabilities.

... does not really have anything to do with how you are using Robot Framework. Maybe this could be removed from the description text, thus shortening it?

The entries (besides the first one) should be in alphabetical order, meaning currently this entry is one off of the correct place: it should come after Condé Nast but before Ficosa.

Do you want to implement based on my suggestion, or should I do my version of how the entry in the list could look?

@rsmparthiban
Copy link

Hi,
Could you please help me to add my company under the robot framework users.

@Tattoo
Copy link
Member

Tattoo commented Jan 10, 2018

@rsmparthiban are you @bkhouri or from CENX?

@pekkaklarck
Copy link
Member

@rsmparthiban You'd like to add a new organization as a user, right? Please submit a new issue about it.

@bkhouri
Copy link
Contributor Author

bkhouri commented Jan 17, 2018

@Tattoo I'm from CENX.

I know the image does not show CENX, but that's the image the marketing team wants to use - don't ask me why. cortx is the product. CENX is the company.

For the text, used whatever the marketing team wanted.

Feel free to update the PR with your revisions.

@Tattoo Tattoo merged commit c6e1156 into robotframework:master Jan 17, 2018
@Tattoo
Copy link
Member

Tattoo commented Jan 17, 2018

@bkhouri ,

I made the changes detailed in my comment. If you want to work on them more, please open a new issue.

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CENX as a user
4 participants