-
Notifications
You must be signed in to change notification settings - Fork 84
Add Browser Library and Update other Libraries #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi, Generally we do not remove libraries based on our own feelings as someone might always find them useful. For example, CNCLibrary is made by us and is still used. I would much rather contact the given lib developers that are they maintaining it and notify if it's still ought to be listed. It would have been great if PR is for one thing only. |
@Tattoo CNCLibrary is Python2 only, not maintained over the last 5 Years, has 5 Open Issues. It is dead! |
You can update the Library and add it again. |
That seems quite a waste of everyone's resources, but have it your way. These things could be announced more widely than "just agreeing in Robocon". It's not like we will run out of space on the web site. |
Android library - 5 Years no commit - 19 open issues @Tattoo what are we talking about? We are not talking about a few month or so! |
Why do you assume some library would be "garbage" just because it hasn't been updated? It could be well-made, providing a base for someone to do a Python 3 version themselves. I can cite you examples just this year where this exact thing has happened. In any case, I agree that some old libraries ought to be removed. However, you are going about this completely backwards. This pruning has not been communicated properly, you do it in a completely unrelated PR making history messy, and you do not contribute to a welcoming, nice community by deciding to remove things on a whim (yes, not notifying people is just that) and then ragging on people's hard work. |
I think i honor peoples hard work. RF.org is imho NOT GitHub. If any maintainer of these libraries would have had any interest that these libraries are still being used, (s)he should have updated to Py3 which is really not a big effort or just accept the PRs about PY3 For example the Developer of RequestsLibrary and ArchiveLibrary actively asked if we could maintain his libraries and they will be transferred to MarketSquare. These stay there. Imho it is our (also yours) task to maintain the page. And that does also mean the content. But having the privilege to be on robotframework.org means also to give a minimum effort of maintenance. Everyone is welcome, IF the library is working. |
I do not understand why you are being so negative and arrogant about very simple thing. I would encourage you to think your behavior, before it puts off more and more people. The way you respond in this thread is really unprofessional and definitely uncool. |
Sorry for being rude! I just think that we should clean in front of our door. In my opinion it is unprofessional to not maintain the page or not delete outdated information from it. Do you honestly believe that one of the developers of the removed libraries is willing to update them? |
Yes, for example my company. As I have already stated. You literally had a response in few minutes. I have also stated that having a library from which one can start from is not a dead end. Your actions and claims do not match here. Finally, this is open source. We share because sharing is virtue by itself. You are here making the same kind of demands as is the classical "entitled user" archetype we have faced many times. This kind of behaviour degrades our community, especially since there would have been easy, nicer, alternative courses of actions. This is not about doing maintenance, of which we agree. |
Hey Tatu, I can remove CNC-Library deletion from the PR if Eficode change it to Python 3 compatibility. Making every deletion in a separate PR imho makes really no sense here as it would be unnecessary effort for Sami to merge and this PR hat one goal. As always every single line of code can be commented and changed before a complete PR is merged. I hope this is fine. |
Separate PR is literally extra minute of work for Sami. Having all deletions in a single PR where you highlight last commiter like this: @Snooz82 - please indicate if we shouldn't remove the library from rf.org. would be basic courtesy and take altogether less than 10 minutes of doing. @IsNoGood : who gets to decide what is "vital" for whom? |
It is not like this. In general i would say, that the foundation decides what is on the rf.org page. And we talked about the page with Pekka and some other and came to the conclusion that libraries that are not Python3 shall be removed. We officially announced on RoboCon that the next Major (4.0) of RF will deprecate Python2. |
You didn't read what I wrote. Again, the point all along here is how you, @Snooz82 , went about doing this in a seriously uncool way. This was not the way to do it. |
We can really discuss this further if you like in privat. But still i do not understand why removing "not working" Libraries from our page is uncool. It is our job to prevent this situation! CNC-Library is back again. |
…ies... (#185) * Added Robot Framework Browser library and cleaned up dead libraries... * Added CNC Library back to the list.
Once again, I think your actions in this thread is the uncool part, not the fact that you are doing maintenance. This is now the third time I have re-iterated this. |
Ok |
Merged and panic reverted, @Snooz82 can you please resubmit PR. The built file was not commited which broke the site. Was just about to write about this: I think for PRs a general rule would be to not include build files, only source files. Minified build files might contain malicious code as there is no way to check if it's actually the result of the build. Also if the build is done improperly, the site might break, as just happened. After PR is merged, I can build the site and check that everything is OK. This has been done before with PR's such as this one: #180 |
Will update readme regarding this |
@Tattoo i think i already tried to apologize for being rude. |
Quick comments:
|
Hi,
The new Browser library should be added to robotframework.org and there are some very old libraries that should be deleted from the page. Others like the SeleniumScreenshots should just have the correct link.
Cheers
The text was updated successfully, but these errors were encountered: