Skip to content

[py] Update test_remote_webdriver.py to use file_names #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

rdinoff
Copy link
Owner

@rdinoff rdinoff commented Jan 25, 2024

files does not get returned in a consistent order from get_downloadable_files() which is why the sort is needed in the assert. Use file_names instead

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

files does not get returned in a consistent order from get_downloadable_files() which is why the sort is needed in the assert.  Use file_names instead
@rdinoff rdinoff merged commit 11a8187 into trunk Jan 25, 2024
@rdinoff
Copy link
Owner Author

rdinoff commented Jan 25, 2024

SeleniumHQ#1568

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant