-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
gh-83994, gh-132843: Fix and improve test_ioctl #132848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
serhiy-storchaka
commented
Apr 23, 2025
•
edited
Loading
edited
- Skip test_ioctl_tcflush if termios.TCFLSH is not available.
- Do not skip ALL ioctl() tests when /dev/tty is not available.
- Issue: test_ioctl skipped -- Unable to open /dev/tty #83994
- Issue: test_ioctl failing on MacOS #132843
* Skip test_ioctl_tcflush if termios.TCFLSH is not available. * Do not skip ALL ioctl() tests when /dev/tty is not available.
This was
linked to
issues
Apr 23, 2025
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, @serhiy-storchaka, I could not cleanly backport this to
|
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Apr 23, 2025
…ythonGH-132848) * Skip test_ioctl_tcflush if termios.TCFLSH is not available. * Do not skip ALL ioctl() tests when /dev/tty is not available. (cherry picked from commit 4b4b9fb) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
GH-132850 is a backport of this pull request to the 3.13 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Apr 23, 2025
There are errors on Android on Python 3.13:
|
Should be fixed in #132878. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.