Skip to content

gh-127604: Allow faulthandler to dumpC stack on MacOS #132841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2025
Merged

gh-127604: Allow faulthandler to dumpC stack on MacOS #132841

merged 2 commits into from
Apr 23, 2025

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Apr 23, 2025 •
edited by bedevere-app bot
Loading

@pablogsal pablogsal requested a review from ZeroIntensity April 23, 2025 14:07
@bedevere-app bedevere-app bot mentioned this pull request Apr 23, 2025
Open
@pablogsal
Copy link
Member Author

pablogsal commented Apr 23, 2025 •
edited
Loading 

❯ ./python.exe -m test test_faulthandler -v | grep c_stack
test_dump_c_stack (test.test_faulthandler.FaultHandlerTests.test_dump_c_stack) ... ok
test_dump_c_stack_file (test.test_faulthandler.FaultHandlerTests.test_dump_c_stack_file) ... ok

~/github/python/main gh-127604* 17s
❯ uname -a
Darwin HWJ59XLTF9 24.4.0 Darwin Kernel Version 24.4.0: Fri Apr 11 18:33:47 PDT 2025; root:xnu-11417.101.15~117/RELEASE_ARM64_T6000 arm64

@pablogsal
pythongh-127604: Allow faulthandler to dumpC stack on MacOS
75e05b8 
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
ZeroIntensity
ZeroIntensity approved these changes Apr 23, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a Mac to test this on, so I'll trust that you've tested this locally. The tests only require that it either spits out <cannot get backtrace> or the actual C backtrace.

@pablogsal
Copy link
Member Author

pablogsal commented Apr 23, 2025 •
edited
Loading

I don't have a Mac to test this on, so I'll trust that you've tested this locally. The tests only require that it either spits out <cannot get backtrace> or the actual C backtrace.

My previous comment was proving exactly that :)

@pablogsal @ZeroIntensity
Apply suggestions from code review
84175cf 
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@pablogsal pablogsal merged commit 1007aab into python:main Apr 23, 2025
41 checks passed
@pablogsal pablogsal deleted the gh-127604 branch April 23, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pablogsal @ZeroIntensity