Skip to content

gh-132747: Fix NULL dereference when calling a method's __get__ manually #132772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 21, 2025
Merged

gh-132747: Fix NULL dereference when calling a method's __get__ manually #132772

merged 5 commits into from
Apr 21, 2025

Conversation

ZeroIntensity
Copy link
Member

@ZeroIntensity ZeroIntensity commented Apr 21, 2025 •
edited by bedevere-app bot
Loading

@ZeroIntensity ZeroIntensity added the needs backport to 3.13 bugs and security fixes label Apr 21, 2025
@bedevere-app bedevere-app bot mentioned this pull request Apr 21, 2025
Closed
@ZeroIntensity ZeroIntensity changed the title gh-132747: Fix NULL dereference when calling a heap type's __get__ manually gh-132747: Fix NULL dereference when calling an object's __get__ manually Apr 21, 2025
@ZeroIntensity ZeroIntensity requested a review from picnixz April 21, 2025 12:21
@ZeroIntensity ZeroIntensity changed the title gh-132747: Fix NULL dereference when calling an object's __get__ manually gh-132747: Fix NULL dereference when calling a method's __get__ manually Apr 21, 2025
@JelleZijlstra JelleZijlstra merged commit fa70bf8 into python:main Apr 21, 2025
50 checks passed
@miss-islington-app
Copy link

Thanks @ZeroIntensity for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @ZeroIntensity and @JelleZijlstra, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker fa70bf85931eff62cb24fb2f5b7e86c1dcf642d0 3.13

@JelleZijlstra
Copy link
Member

@ZeroIntensity do you want to do the backport?

@ZeroIntensity ZeroIntensity deleted the gh-132747-descriptor-crash branch April 21, 2025 21:11
ZeroIntensity added a commit to ZeroIntensity/cpython that referenced this pull request Apr 21, 2025
@ZeroIntensity
[3.13] pythongh-132747: Fix NULL dereference when calling a method'…
e15d524 
…s `__get__` manually (pythonGH-132772)

(cherry picked from commit fa70bf8)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Apr 21, 2025

GH-132786 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Apr 21, 2025
JelleZijlstra pushed a commit that referenced this pull request Apr 21, 2025
@ZeroIntensity
[3.13] gh-132747: Fix NULL dereference when calling a method's `__g…
bb59fde 
…et__` manually (GH-132772) (#132786)

(cherry picked from commit fa70bf8)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@picnixz picnixz Awaiting requested review from picnixz

Assignees

@ZeroIntensity ZeroIntensity

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZeroIntensity @JelleZijlstra